From: Alexandre Courbot <gnurou@gmail.com>
To: weiyj_lk@163.com
Cc: Linus Walleij <linus.walleij@linaro.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH -next] gpio: Fix return value check in xgene_gpio_probe()
Date: Fri, 19 Sep 2014 17:40:30 +0900 [thread overview]
Message-ID: <CAAVeFu+aVzSy1HaoeOyeaJ2=ArjOctgEOLdp-i7Q66muZ7E5tw@mail.gmail.com> (raw)
In-Reply-To: <1410477134-5556-1-git-send-email-weiyj_lk@163.com>
On Fri, Sep 12, 2014 at 8:12 AM, <weiyj_lk@163.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> In case of error, the function devm_ioremap_nocache() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
next prev parent reply other threads:[~2014-09-19 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 23:12 [PATCH -next] gpio: Fix return value check in xgene_gpio_probe() weiyj_lk
2014-09-19 8:40 ` Alexandre Courbot [this message]
2014-09-24 8:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAVeFu+aVzSy1HaoeOyeaJ2=ArjOctgEOLdp-i7Q66muZ7E5tw@mail.gmail.com' \
--to=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=weiyj_lk@163.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).