From: Alexandre Courbot <gnurou@gmail.com>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables
Date: Mon, 9 Nov 2015 08:53:04 +0900 [thread overview]
Message-ID: <CAAVeFuJT7uxbQ_rf2o=6w4Ub3aW4Lhn_ED_JQZ+TNpORAVom8A@mail.gmail.com> (raw)
In-Reply-To: <20151104123008.GA15302@sophia>
On Wed, Nov 4, 2015 at 9:30 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
> To prevent confusion and to match existing coding style used in other
> gpio drivers symbol names within the 104-idio-16 gpio driver should be
> lowercase.
... and for the same styling reasons "GPIO" should be spelled in
uppercase in your commit message. ;)
Apart from that this patch seems harmless and the repositioning of
some constant declarations is also welcome.
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
next prev parent reply other threads:[~2015-11-08 23:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 12:30 [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables William Breathitt Gray
2015-11-08 23:53 ` Alexandre Courbot [this message]
2015-11-09 1:28 ` William Breathitt Gray
2015-11-09 6:09 ` Alexandre Courbot
2015-11-17 11:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAVeFuJT7uxbQ_rf2o=6w4Ub3aW4Lhn_ED_JQZ+TNpORAVom8A@mail.gmail.com' \
--to=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vilhelm.gray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).