From: Alexandre Courbot <gnurou@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Alexandre Courbot <acourbot@nvidia.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 1/4] mmc: slot-gpio: switch to use flags when getting GPIO
Date: Wed, 24 Sep 2014 16:38:18 +0900 [thread overview]
Message-ID: <CAAVeFuK+RLFu-RgU-qyKe7rj2kgVDBVxXgBeg-teLo2NXLEfYA@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbBq0VCBAOv7QX8pk73-_hU5Yy6QWURr5NohpG+osaYow@mail.gmail.com>
On Mon, Sep 22, 2014 at 9:37 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Sep 22, 2014 at 10:20 AM, Adrian Hunter <adrian.hunter@intel.com> wrote:
>
>> Unfortunately it doesn't seem to work. I needed the patch
>> below.
>>
>>
>> From: Adrian Hunter <adrian.hunter@intel.com>
>> Date: Mon, 22 Sep 2014 11:01:16 +0300
>> Subject: [PATCH] gpio: Fix gpio direction flags not getting set
>>
>> GPIO direction flags are not getting set because
>> an 'if' statement is the wrong way around.
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>
> Oopps that's a bug, patch applied for fixes, so it'll work when
> this hits upstream.
>
> Alex: confirm?
Oh yes absolutely, this was a mistake of mine. Thanks and sorry for
the inconvenience.
next prev parent reply other threads:[~2014-09-24 7:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 11:00 [PATCH 1/4] mmc: slot-gpio: switch to use flags when getting GPIO Linus Walleij
2014-08-27 11:00 ` [PATCH 2/4] mmc: slot-gpio: add gpiod variant to get wp GPIO Linus Walleij
2014-08-29 12:16 ` Ulf Hansson
2014-08-27 11:00 ` [PATCH 3/4 v2] mmc: host: switch OF parser to use gpio descriptors Linus Walleij
2014-08-29 12:16 ` Ulf Hansson
2014-09-09 7:05 ` Linus Walleij
2014-09-09 12:29 ` Ulf Hansson
2014-09-30 11:30 ` Javier Martinez Canillas
2014-09-30 14:01 ` Linus Walleij
2014-08-27 11:00 ` [PATCH 4/4] mmc: mmci: augment driver to handle " Linus Walleij
2014-08-27 11:34 ` Ulf Hansson
2014-08-29 12:16 ` [PATCH 1/4] mmc: slot-gpio: switch to use flags when getting GPIO Ulf Hansson
2014-09-22 8:20 ` Adrian Hunter
2014-09-22 12:37 ` Linus Walleij
2014-09-24 7:38 ` Alexandre Courbot [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-08-12 17:25 Linus Walleij
2014-08-14 14:28 ` Alexandre Courbot
2014-08-18 11:25 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAVeFuK+RLFu-RgU-qyKe7rj2kgVDBVxXgBeg-teLo2NXLEfYA@mail.gmail.com \
--to=gnurou@gmail.com \
--cc=acourbot@nvidia.com \
--cc=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).