* [PATCH 1/1] gpio: gpiolib: fix identation
@ 2015-09-24 7:14 Olliver Schinagl
2015-09-24 7:17 ` Alexandre Courbot
0 siblings, 1 reply; 3+ messages in thread
From: Olliver Schinagl @ 2015-09-24 7:14 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot, Mika Westerberg
Cc: linux-gpio, linux-kernel, Olliver Schinagl
From: Olliver Schinagl <oliver@schinagl.nl>
Just a very small cosmetical indentation fix, no code changes
Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
---
drivers/gpio/gpiolib.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 980c1f8..5ef9ac2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1746,6 +1746,8 @@ static struct gpio_desc *acpi_find_gpio(struct device *dev, const char *con_id,
if (con_id && strcmp(con_id, "gpios")) {
snprintf(propname, sizeof(propname), "%s-%s",
con_id, gpio_suffixes[i]);
+ if (!IS_ERR(desc) || (PTR_ERR(desc) == -EPROBE_DEFER))
+ break;
} else {
snprintf(propname, sizeof(propname), "%s",
gpio_suffixes[i]);
--
2.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] gpio: gpiolib: fix identation
2015-09-24 7:14 [PATCH 1/1] gpio: gpiolib: fix identation Olliver Schinagl
@ 2015-09-24 7:17 ` Alexandre Courbot
2015-09-24 7:39 ` Olliver Schinagl
0 siblings, 1 reply; 3+ messages in thread
From: Alexandre Courbot @ 2015-09-24 7:17 UTC (permalink / raw)
To: Olliver Schinagl
Cc: Linus Walleij, Mika Westerberg, linux-gpio@vger.kernel.org,
Linux Kernel Mailing List, Olliver Schinagl
On Thu, Sep 24, 2015 at 4:14 PM, Olliver Schinagl
<oliver+list@schinagl.nl> wrote:
> From: Olliver Schinagl <oliver@schinagl.nl>
>
> Just a very small cosmetical indentation fix, no code changes
You are adding two lines and not removing any, so it is not just a
cosmetic fix and actually adds code.
>
> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> ---
> drivers/gpio/gpiolib.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 980c1f8..5ef9ac2 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -1746,6 +1746,8 @@ static struct gpio_desc *acpi_find_gpio(struct device *dev, const char *con_id,
> if (con_id && strcmp(con_id, "gpios")) {
> snprintf(propname, sizeof(propname), "%s-%s",
> con_id, gpio_suffixes[i]);
> + if (!IS_ERR(desc) || (PTR_ERR(desc) == -EPROBE_DEFER))
> + break;
> } else {
> snprintf(propname, sizeof(propname), "%s",
> gpio_suffixes[i]);
> --
> 2.5.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] gpio: gpiolib: fix identation
2015-09-24 7:17 ` Alexandre Courbot
@ 2015-09-24 7:39 ` Olliver Schinagl
0 siblings, 0 replies; 3+ messages in thread
From: Olliver Schinagl @ 2015-09-24 7:39 UTC (permalink / raw)
To: Alexandre Courbot, Olliver Schinagl
Cc: Linus Walleij, Mika Westerberg, linux-gpio@vger.kernel.org,
Linux Kernel Mailing List
Appologies! I should not do this early in the morning. It is indeed a
copy/paste fail (and not noticing the missing minus) from the section
above i was working on.
I'm sorry for the noise!
Olliver
On 24-09-15 09:17, Alexandre Courbot wrote:
> On Thu, Sep 24, 2015 at 4:14 PM, Olliver Schinagl
> <oliver+list@schinagl.nl> wrote:
>> From: Olliver Schinagl <oliver@schinagl.nl>
>>
>> Just a very small cosmetical indentation fix, no code changes
> You are adding two lines and not removing any, so it is not just a
> cosmetic fix and actually adds code.
>
>> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
>> ---
>> drivers/gpio/gpiolib.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
>> index 980c1f8..5ef9ac2 100644
>> --- a/drivers/gpio/gpiolib.c
>> +++ b/drivers/gpio/gpiolib.c
>> @@ -1746,6 +1746,8 @@ static struct gpio_desc *acpi_find_gpio(struct device *dev, const char *con_id,
>> if (con_id && strcmp(con_id, "gpios")) {
>> snprintf(propname, sizeof(propname), "%s-%s",
>> con_id, gpio_suffixes[i]);
>> + if (!IS_ERR(desc) || (PTR_ERR(desc) == -EPROBE_DEFER))
>> + break;
>> } else {
>> snprintf(propname, sizeof(propname), "%s",
>> gpio_suffixes[i]);
>> --
>> 2.5.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-24 7:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-24 7:14 [PATCH 1/1] gpio: gpiolib: fix identation Olliver Schinagl
2015-09-24 7:17 ` Alexandre Courbot
2015-09-24 7:39 ` Olliver Schinagl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).