linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Courbot <gnurou@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Jonas Jensen <jonas.jensen@gmail.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] gpio: moxart: Actually set output state in moxart_gpio_direction_output()
Date: Tue, 25 Mar 2014 11:35:29 +0900	[thread overview]
Message-ID: <CAAVeFuKgtne_dcy5Gpc3HTBUttpN6jqna1wEBwaNmjM+cJCoYA@mail.gmail.com> (raw)
In-Reply-To: <1395714491.5096.0.camel@phoenix>

On Tue, Mar 25, 2014 at 11:28 AM, Axel Lin <axel.lin@ingics.com> wrote:
> moxart_gpio_direction_output() ignored the state passed into it. Fix it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/gpio/gpio-moxart.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpio/gpio-moxart.c b/drivers/gpio/gpio-moxart.c
> index 2af9900..4bd81f9 100644
> --- a/drivers/gpio/gpio-moxart.c
> +++ b/drivers/gpio/gpio-moxart.c
> @@ -33,6 +33,8 @@ struct moxart_gpio_chip {
>         void __iomem *base;
>  };
>
> +static void moxart_gpio_set(struct gpio_chip *chip, unsigned offset, int value);

Just reverse the order of your patches, and you don't have to make
this declaration at all.

It makes little sense to introduce a forward-declaration in a patch
and remove it in the very next.

      parent reply	other threads:[~2014-03-25  2:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-25  2:28 [PATCH v2 1/2] gpio: moxart: Actually set output state in moxart_gpio_direction_output() Axel Lin
2014-03-25  2:29 ` [PATCH v2 2/2] gpio: moxart: Avoid forward declaration Axel Lin
2014-03-25  2:35 ` Alexandre Courbot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAVeFuKgtne_dcy5Gpc3HTBUttpN6jqna1wEBwaNmjM+cJCoYA@mail.gmail.com \
    --to=gnurou@gmail.com \
    --cc=axel.lin@ingics.com \
    --cc=jonas.jensen@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).