linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Courbot <gnurou@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <acourbot@nvidia.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 2/3] gpio: move sysfs support to its own file
Date: Tue, 8 Jul 2014 17:31:01 +0900	[thread overview]
Message-ID: <CAAVeFuKrvvmWGS0OaP+JBmozT70K9=0ntL7Zx+vZPBjr2H8aDg@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdaRReCWObTBP-ujiM-R9Js2y+L6RFtAfw6AP1cwx1hrHA@mail.gmail.com>

On Tue, Jul 8, 2014 at 5:21 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Jul 1, 2014 at 7:45 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:
>
>> sysfs support is currently entangled within the core GPIO support, while
>> it should relly just be a (privileged) user of the integer GPIO API.
>> This patch is a first step towards making the gpiolib code more readable
>> by splitting it into logical parts.
>>
>> Move all sysfs support to their own source file, and share static
>> members of gpiolib that need to be in the private gpiolib.h file. In
>> the future we will want to put some of them back into gpiolib.c, but this
>> first patch let us at least identify them.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>
> Patch applied. We really need to make refactorings like this
> so thanks a lot.

Excellent, glad you approve of this. I actually have some more coming
after that, since the current lack of organization stands in the way
of a proper multi-consumer GPIO implementation.

Thanks!
Alex.

  reply	other threads:[~2014-07-08  8:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01  5:45 [RFC 0/3] gpio: move interfaces into their own files Alexandre Courbot
2014-07-01  5:45 ` [RFC 1/3] gpio: always compile label support Alexandre Courbot
2014-07-08  8:17   ` Linus Walleij
2014-07-01  5:45 ` [RFC 2/3] gpio: move sysfs support to its own file Alexandre Courbot
2014-07-08  8:21   ` Linus Walleij
2014-07-08  8:31     ` Alexandre Courbot [this message]
2014-07-01  5:45 ` [RFC 3/3] gpio: move integer GPIO " Alexandre Courbot
2014-07-08  8:25   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAVeFuKrvvmWGS0OaP+JBmozT70K9=0ntL7Zx+vZPBjr2H8aDg@mail.gmail.com' \
    --to=gnurou@gmail.com \
    --cc=acourbot@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).