linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Courbot <gnurou@gmail.com>
To: Rojhalat Ibrahim <imr@rtschenk.de>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <acourbot@nvidia.com>,
	David Miller <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	David Daney <david.daney@cavium.com>
Subject: Re: [PATCH][v3] mdio-mux-gpio: Use GPIO descriptor interface and new gpiod_set_array function
Date: Fri, 28 Nov 2014 13:30:40 +0900	[thread overview]
Message-ID: <CAAVeFuLDgLXGAedBYOWJqEJvxFAOAv_z6rwHpPyYVZyXx5XHgQ@mail.gmail.com> (raw)
In-Reply-To: <1581158.UhESICdgeM@pcimr>

On Tue, Nov 25, 2014 at 10:57 PM, Rojhalat Ibrahim <imr@rtschenk.de> wrote:
> Convert mdio-mux-gpio to the GPIO descriptor interface and use the new
> gpiod_set_array function to set all output signals simultaneously.
>
> Signed-off-by: Rojhalat Ibrahim <imr@rtschenk.de>
> Acked-by: David S. Miller <davem@davemloft.net>
> --
> This patch depends on the gpiod_set_array function, which is available in
> the linux-gpio devel tree.
>
> Change log:
>   v3: remove unnecessary braces
>   v2: fix gpiod_get_index usage
>
>  drivers/net/phy/mdio-mux-gpio.c |   37 +++++++++++++------------------------
>  1 file changed, 13 insertions(+), 24 deletions(-)

Looks all good to me! Nice use of this new interface, leading to
simpler client code.

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

  reply	other threads:[~2014-11-28  4:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 13:57 [PATCH][v3] mdio-mux-gpio: Use GPIO descriptor interface and new gpiod_set_array function Rojhalat Ibrahim
2014-11-28  4:30 ` Alexandre Courbot [this message]
2014-11-28 15:56 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAVeFuLDgLXGAedBYOWJqEJvxFAOAv_z6rwHpPyYVZyXx5XHgQ@mail.gmail.com \
    --to=gnurou@gmail.com \
    --cc=acourbot@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=david.daney@cavium.com \
    --cc=f.fainelli@gmail.com \
    --cc=imr@rtschenk.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).