[PATCH 0/3] Add Fintek F71869 and F71869A gpio support

[PATCH 0/3] Add Fintek F71869 and F71869A gpio support

[Andreas Bofjall]

Hi,

this series adds support for the gpio pins on the Fintek F71869 and F71869A
SuperI/O chips to the gpio-f7188x driver. The chips are used on for example
Jetway motherboards.

The driver has been tested on two different boards: a JNF99-525 with F71869A,
and by Les Schaffer on a Jetway NF96u-525 with F71869.

Andreas Bofjall (3):
  gpio: f7188x: correct spelling of "Fintek"
  gpio: f7188x: add GPIO support for F71869
  gpio: f7188x: add GPIO support for F71869A

 drivers/gpio/Kconfig       |  4 ++--
 drivers/gpio/gpio-f7188x.c | 47 ++++++++++++++++++++++++++++++++++++++++++----
 2 files changed, 45 insertions(+), 6 deletions(-)

-- 
2.1.4

[PATCH 1/3] gpio: f7188x: correct spelling of "Fintek"

[Andreas Bofjall]

The company is called "Fintek", not "Fintech". Fix it.

Signed-off-by: Andreas Bofjall <andreas@gazonk.org>
---
 drivers/gpio/gpio-f7188x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
index fd3202f..53be51d 100644
--- a/drivers/gpio/gpio-f7188x.c
+++ b/drivers/gpio/gpio-f7188x.c
@@ -410,7 +410,7 @@ err:
 }
 
 /*
- * Try to match a supported Fintech device by reading the (hard-wired)
+ * Try to match a supported Fintek device by reading the (hard-wired)
  * configuration I/O ports. If available, then register both the platform
  * device and driver to support the GPIOs.
  */
-- 
2.1.4

[PATCH 2/3] gpio: f7188x: add GPIO support for F71869

[Andreas Bofjall]

Add support for the GPIOs found on the Fintek SuperI/O chip F71869, such
as the one found on the Jetway NF96u-525 motherboard, to the f7188x gpio
driver.

Signed-off-by: Andreas Bofjall <andreas@gazonk.org>
Tested-by: Les Schaffer <schaffer@optonline.net>
---
 drivers/gpio/Kconfig       |  4 ++--
 drivers/gpio/gpio-f7188x.c | 25 ++++++++++++++++++++++---
 2 files changed, 24 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 9de1515..26d1667 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -173,11 +173,11 @@ config GPIO_MM_LANTIQ
 	  created by attaching a 16bit latch to the bus.
 
 config GPIO_F7188X
-	tristate "F71882FG and F71889F GPIO support"
+	tristate "F71869, F71882FG and F71889F GPIO support"
 	depends on X86
 	help
 	  This option enables support for GPIOs found on Fintek Super-I/O
-	  chips F71882FG and F71889F.
+	  chips F71869, F71882FG and F71889F.
 
 	  To compile this driver as a module, choose M here: the module will
 	  be called f7188x-gpio.
diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
index 53be51d..fe0bc8c 100644
--- a/drivers/gpio/gpio-f7188x.c
+++ b/drivers/gpio/gpio-f7188x.c
@@ -1,5 +1,5 @@
 /*
- * GPIO driver for Fintek Super-I/O F71882 and F71889
+ * GPIO driver for Fintek Super-I/O F71869, F71882 and F71889
  *
  * Copyright (C) 2010-2013 LaCie
  *
@@ -32,12 +32,14 @@
 #define SIO_LOCK_KEY		0xAA	/* Key to disable Super-I/O */
 
 #define SIO_FINTEK_ID		0x1934	/* Manufacturer ID */
+#define SIO_F71869_ID		0x0814	/* F71869 chipset ID */
 #define SIO_F71882_ID		0x0541	/* F71882 chipset ID */
 #define SIO_F71889_ID		0x0909	/* F71889 chipset ID */
 
-enum chips { f71882fg, f71889f };
+enum chips { f71869, f71882fg, f71889f };
 
 static const char * const f7188x_names[] = {
+	"f71869",
 	"f71882fg",
 	"f71889f",
 };
@@ -146,6 +148,16 @@ static void f7188x_gpio_set(struct gpio_chip *chip, unsigned offset, int value);
 /* Output mode register (0:open drain 1:push-pull). */
 #define gpio_out_mode(base) (base + 3)
 
+static struct f7188x_gpio_bank f71869_gpio_bank[] = {
+	F7188X_GPIO_BANK(0, 6, 0xF0),
+	F7188X_GPIO_BANK(10, 8, 0xE0),
+	F7188X_GPIO_BANK(20, 8, 0xD0),
+	F7188X_GPIO_BANK(30, 8, 0xC0),
+	F7188X_GPIO_BANK(40, 8, 0xB0),
+	F7188X_GPIO_BANK(50, 5, 0xA0),
+	F7188X_GPIO_BANK(60, 6, 0x90),
+};
+
 static struct f7188x_gpio_bank f71882_gpio_bank[] = {
 	F7188X_GPIO_BANK(0 , 8, 0xF0),
 	F7188X_GPIO_BANK(10, 8, 0xE0),
@@ -281,6 +293,10 @@ static int f7188x_gpio_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	switch (sio->type) {
+	case f71869:
+		data->nr_bank = ARRAY_SIZE(f71869_gpio_bank);
+		data->bank = f71869_gpio_bank;
+		break;
 	case f71882fg:
 		data->nr_bank = ARRAY_SIZE(f71882_gpio_bank);
 		data->bank = f71882_gpio_bank;
@@ -354,6 +370,9 @@ static int __init f7188x_find(int addr, struct f7188x_sio *sio)
 
 	devid = superio_inw(addr, SIO_DEVID);
 	switch (devid) {
+	case SIO_F71869_ID:
+		sio->type = f71869;
+		break;
 	case SIO_F71882_ID:
 		sio->type = f71882fg;
 		break;
@@ -451,6 +470,6 @@ static void __exit f7188x_gpio_exit(void)
 }
 module_exit(f7188x_gpio_exit);
 
-MODULE_DESCRIPTION("GPIO driver for Super-I/O chips F71882FG and F71889F");
+MODULE_DESCRIPTION("GPIO driver for Super-I/O chips F71869, F71882FG and F71889F");
 MODULE_AUTHOR("Simon Guinot <simon.guinot@sequanux.org>");
 MODULE_LICENSE("GPL");
-- 
2.1.4

[PATCH 3/3] gpio: f7188x: add GPIO support for F71869A

[Andreas Bofjall]

Add support for the GPIOs found on the Fintek SuperI/O chip F71869A,
such as the one found on the Jetway JNF99-525 motherboard, to the f7188x
gpio driver.

Signed-off-by: Andreas Bofjall <andreas@gazonk.org>
---
 drivers/gpio/Kconfig       |  4 ++--
 drivers/gpio/gpio-f7188x.c | 26 +++++++++++++++++++++++---
 2 files changed, 25 insertions(+), 5 deletions(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 26d1667..79c16f5 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -173,11 +173,11 @@ config GPIO_MM_LANTIQ
 	  created by attaching a 16bit latch to the bus.
 
 config GPIO_F7188X
-	tristate "F71869, F71882FG and F71889F GPIO support"
+	tristate "F71869, F71869A, F71882FG and F71889F GPIO support"
 	depends on X86
 	help
 	  This option enables support for GPIOs found on Fintek Super-I/O
-	  chips F71869, F71882FG and F71889F.
+	  chips F71869, F71869A, F71882FG and F71889F.
 
 	  To compile this driver as a module, choose M here: the module will
 	  be called f7188x-gpio.
diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
index fe0bc8c..fa0e482 100644
--- a/drivers/gpio/gpio-f7188x.c
+++ b/drivers/gpio/gpio-f7188x.c
@@ -1,5 +1,5 @@
 /*
- * GPIO driver for Fintek Super-I/O F71869, F71882 and F71889
+ * GPIO driver for Fintek Super-I/O F71869, F71869A, F71882 and F71889
  *
  * Copyright (C) 2010-2013 LaCie
  *
@@ -33,13 +33,15 @@
 
 #define SIO_FINTEK_ID		0x1934	/* Manufacturer ID */
 #define SIO_F71869_ID		0x0814	/* F71869 chipset ID */
+#define SIO_F71869A_ID		0x1007	/* F71869A chipset ID */
 #define SIO_F71882_ID		0x0541	/* F71882 chipset ID */
 #define SIO_F71889_ID		0x0909	/* F71889 chipset ID */
 
-enum chips { f71869, f71882fg, f71889f };
+enum chips { f71869, f71869a, f71882fg, f71889f };
 
 static const char * const f7188x_names[] = {
 	"f71869",
+	"f71869a",
 	"f71882fg",
 	"f71889f",
 };
@@ -158,6 +160,17 @@ static struct f7188x_gpio_bank f71869_gpio_bank[] = {
 	F7188X_GPIO_BANK(60, 6, 0x90),
 };
 
+static struct f7188x_gpio_bank f71869a_gpio_bank[] = {
+	F7188X_GPIO_BANK(0, 6, 0xF0),
+	F7188X_GPIO_BANK(10, 8, 0xE0),
+	F7188X_GPIO_BANK(20, 8, 0xD0),
+	F7188X_GPIO_BANK(30, 8, 0xC0),
+	F7188X_GPIO_BANK(40, 8, 0xB0),
+	F7188X_GPIO_BANK(50, 5, 0xA0),
+	F7188X_GPIO_BANK(60, 8, 0x90),
+	F7188X_GPIO_BANK(70, 8, 0x80),
+};
+
 static struct f7188x_gpio_bank f71882_gpio_bank[] = {
 	F7188X_GPIO_BANK(0 , 8, 0xF0),
 	F7188X_GPIO_BANK(10, 8, 0xE0),
@@ -297,6 +310,10 @@ static int f7188x_gpio_probe(struct platform_device *pdev)
 		data->nr_bank = ARRAY_SIZE(f71869_gpio_bank);
 		data->bank = f71869_gpio_bank;
 		break;
+	case f71869a:
+		data->nr_bank = ARRAY_SIZE(f71869a_gpio_bank);
+		data->bank = f71869a_gpio_bank;
+		break;
 	case f71882fg:
 		data->nr_bank = ARRAY_SIZE(f71882_gpio_bank);
 		data->bank = f71882_gpio_bank;
@@ -373,6 +390,9 @@ static int __init f7188x_find(int addr, struct f7188x_sio *sio)
 	case SIO_F71869_ID:
 		sio->type = f71869;
 		break;
+	case SIO_F71869A_ID:
+		sio->type = f71869a;
+		break;
 	case SIO_F71882_ID:
 		sio->type = f71882fg;
 		break;
@@ -470,6 +490,6 @@ static void __exit f7188x_gpio_exit(void)
 }
 module_exit(f7188x_gpio_exit);
 
-MODULE_DESCRIPTION("GPIO driver for Super-I/O chips F71869, F71882FG and F71889F");
+MODULE_DESCRIPTION("GPIO driver for Super-I/O chips F71869, F71869A, F71882FG and F71889F");
 MODULE_AUTHOR("Simon Guinot <simon.guinot@sequanux.org>");
 MODULE_LICENSE("GPL");
-- 
2.1.4

Re: [PATCH 0/3] Add Fintek F71869 and F71869A gpio support

[Alexandre Courbot]

On Mon, Jan 26, 2015 at 2:16 AM, Andreas Bofjall <andreas@gazonk.org> wrote:
> Hi,
>
> this series adds support for the gpio pins on the Fintek F71869 and F71869A
> SuperI/O chips to the gpio-f7188x driver. The chips are used on for example
> Jetway motherboards.
>
> The driver has been tested on two different boards: a JNF99-525 with F71869A,
> and by Les Schaffer on a Jetway NF96u-525 with F71869.

The series,

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

Apologies for taking so long to check it out!

>
> Andreas Bofjall (3):
>   gpio: f7188x: correct spelling of "Fintek"
>   gpio: f7188x: add GPIO support for F71869
>   gpio: f7188x: add GPIO support for F71869A
>
>  drivers/gpio/Kconfig       |  4 ++--
>  drivers/gpio/gpio-f7188x.c | 47 ++++++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 45 insertions(+), 6 deletions(-)
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Add Fintek F71869 and F71869A gpio support

[Andreas Bofjäll]

On Thu, 26 Feb 2015, Alexandre Courbot wrote:
> On Mon, Jan 26, 2015 at 2:16 AM, Andreas Bofjall <andreas@gazonk.org> wrote:
>> this series adds support for the gpio pins on the Fintek F71869 and F71869A
>> SuperI/O chips to the gpio-f7188x driver. The chips are used on for example
>> Jetway motherboards.
>>
>> The driver has been tested on two different boards: a JNF99-525 with F71869A,
>> and by Les Schaffer on a Jetway NF96u-525 with F71869.
>
> The series,
>
> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
>
> Apologies for taking so long to check it out!

Hi and thanks!

How do you normally handle this, would you like me to re-spin the patchset 
with the Reviewed-by set?

/Andreas

Re: [PATCH 0/3] Add Fintek F71869 and F71869A gpio support

[Alexandre Courbot]

On Sat, Feb 28, 2015 at 7:33 AM, Andreas Bofjäll <andreas@gazonk.org> wrote:
> On Thu, 26 Feb 2015, Alexandre Courbot wrote:
>>
>> On Mon, Jan 26, 2015 at 2:16 AM, Andreas Bofjall <andreas@gazonk.org>
>> wrote:
>>>
>>> this series adds support for the gpio pins on the Fintek F71869 and
>>> F71869A
>>> SuperI/O chips to the gpio-f7188x driver. The chips are used on for
>>> example
>>> Jetway motherboards.
>>>
>>> The driver has been tested on two different boards: a JNF99-525 with
>>> F71869A,
>>> and by Les Schaffer on a Jetway NF96u-525 with F71869.
>>
>>
>> The series,
>>
>> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
>>
>> Apologies for taking so long to check it out!
>
>
> Hi and thanks!
>
> How do you normally handle this, would you like me to re-spin the patchset
> with the Reviewed-by set?

No, the maintainer will add the tags you received when applying the
patches. Unless you are explicitly asked to re-send a version for
other reasons, then it is a good idea to append the tags yourself or
they might get lost.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Add Fintek F71869 and F71869A gpio support

[Linus Walleij]

On Thu, Feb 26, 2015 at 10:36 AM, Alexandre Courbot <gnurou@gmail.com> wrote:
> On Mon, Jan 26, 2015 at 2:16 AM, Andreas Bofjall <andreas@gazonk.org> wrote:
>> Hi,
>>
>> this series adds support for the gpio pins on the Fintek F71869 and F71869A
>> SuperI/O chips to the gpio-f7188x driver. The chips are used on for example
>> Jetway motherboards.
>>
>> The driver has been tested on two different boards: a JNF99-525 with F71869A,
>> and by Les Schaffer on a Jetway NF96u-525 with F71869.
>
> The series,
>
> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
>
> Apologies for taking so long to check it out!

I can't see patches 1/3, 2/3 and 3/3 from this patch series.
Was it even sent To: me and the linux-gpio@vger mailing list?

Something is wrong anyway, so please resend the whole patch set
add Alexandre's ACK and I will look at it.

Yours,
Linus Walleij

Re: [PATCH 0/3] Add Fintek F71869 and F71869A gpio support

[Andreas Bofjäll]

On Mon, 9 Mar 2015, Linus Walleij wrote:

> On Thu, Feb 26, 2015 at 10:36 AM, Alexandre Courbot <gnurou@gmail.com> wrote:
>> On Mon, Jan 26, 2015 at 2:16 AM, Andreas Bofjall <andreas@gazonk.org> wrote:
>>> Hi,
>>>
>>> this series adds support for the gpio pins on the Fintek F71869 and F71869A
>>> SuperI/O chips to the gpio-f7188x driver. The chips are used on for example
>>> Jetway motherboards.
>>>
>>> The driver has been tested on two different boards: a JNF99-525 with F71869A,
>>> and by Les Schaffer on a Jetway NF96u-525 with F71869.
>>
>> The series,
>>
>> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
>>
>> Apologies for taking so long to check it out!
>
> I can't see patches 1/3, 2/3 and 3/3 from this patch series.
> Was it even sent To: me and the linux-gpio@vger mailing list?

They were all sent To: linux-gpio@vger.kernel.org using git-send-email, 
but not specifically to you. I see them in the mailing list archive:

http://thread.gmane.org/gmane.linux.kernel.gpio/5887/focus=5888

> Something is wrong anyway, so please resend the whole patch set
> add Alexandre's ACK and I will look at it.

Ok, I'll do so and add both the list and you as recipients.

/Andreas