* [PATCH V4 0/2] gpio: sprd: Modification of UNISOC Platform EIC Driver
@ 2024-01-09 7:38 Wenhua Lin
2024-01-09 7:38 ` [PATCH V4 1/2] gpio: eic-sprd: Clear interrupt after set the interrupt type Wenhua Lin
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Wenhua Lin @ 2024-01-09 7:38 UTC (permalink / raw)
To: Linus Walleij, Andy Shevchenko, Bartosz Golaszewski
Cc: Orson Zhai, Baolin Wang, Chunyan Zhang, linux-gpio, linux-kernel,
wenhua lin, Wenhua Lin, Xiongpeng Wu
Recently, some bugs have been discovered during use, and patch1
are bug fixes. Also, this patchset add optimization:
patch2 optimization the calculation method of eic number.
Change in V4:
-Add Fixes tag in PATCH 1/2.
-Change commit message in PATCH 1/2.
-Add clearing interrupt to debounce and latch mode in PATCH 1/2.
-Change commit message in PATCH 2/2.
-Delete SPRD_EIC_VAR_DATA macro in PATCH 2/2.
Wenhua Lin (2):
gpio: eic-sprd: Clear interrupt after set the interrupt type
gpio: eic-sprd: Optimize the calculation method of eic number
drivers/gpio/gpio-eic-sprd.c | 42 +++++++++++++++++++++++++++---------
1 file changed, 32 insertions(+), 10 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH V4 1/2] gpio: eic-sprd: Clear interrupt after set the interrupt type
2024-01-09 7:38 [PATCH V4 0/2] gpio: sprd: Modification of UNISOC Platform EIC Driver Wenhua Lin
@ 2024-01-09 7:38 ` Wenhua Lin
2024-01-22 10:00 ` Chunyan Zhang
2024-01-09 7:38 ` [PATCH V4 2/2] gpio: eic-sprd: Optimize the calculation method of eic number Wenhua Lin
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Wenhua Lin @ 2024-01-09 7:38 UTC (permalink / raw)
To: Linus Walleij, Andy Shevchenko, Bartosz Golaszewski
Cc: Orson Zhai, Baolin Wang, Chunyan Zhang, linux-gpio, linux-kernel,
wenhua lin, Wenhua Lin, Xiongpeng Wu
The raw interrupt status of eic maybe set before the interrupt is enabled,
since the eic interrupt has a latch function, which would trigger the
interrupt event once enabled it from user side. To solve this problem,
interrupts generated before setting the interrupt trigger type are ignored.
Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
---
drivers/gpio/gpio-eic-sprd.c | 32 ++++++++++++++++++++++++++++----
1 file changed, 28 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
index be7f2fa5aa7b..806b88d8dfb7 100644
--- a/drivers/gpio/gpio-eic-sprd.c
+++ b/drivers/gpio/gpio-eic-sprd.c
@@ -330,20 +330,27 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
switch (flow_type) {
case IRQ_TYPE_LEVEL_HIGH:
sprd_eic_update(chip, offset, SPRD_EIC_DBNC_IEV, 1);
+ sprd_eic_update(chip, offset, SPRD_EIC_DBNC_IC, 1);
break;
case IRQ_TYPE_LEVEL_LOW:
sprd_eic_update(chip, offset, SPRD_EIC_DBNC_IEV, 0);
+ sprd_eic_update(chip, offset, SPRD_EIC_DBNC_IC, 1);
break;
case IRQ_TYPE_EDGE_RISING:
case IRQ_TYPE_EDGE_FALLING:
case IRQ_TYPE_EDGE_BOTH:
state = sprd_eic_get(chip, offset);
- if (state)
+ if (state) {
sprd_eic_update(chip, offset,
SPRD_EIC_DBNC_IEV, 0);
- else
+ sprd_eic_update(chip, offset,
+ SPRD_EIC_DBNC_IC, 1);
+ } else {
sprd_eic_update(chip, offset,
SPRD_EIC_DBNC_IEV, 1);
+ sprd_eic_update(chip, offset,
+ SPRD_EIC_DBNC_IC, 1);
+ }
break;
default:
return -ENOTSUPP;
@@ -355,20 +362,27 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
switch (flow_type) {
case IRQ_TYPE_LEVEL_HIGH:
sprd_eic_update(chip, offset, SPRD_EIC_LATCH_INTPOL, 0);
+ sprd_eic_update(chip, offset, SPRD_EIC_LATCH_INTCLR, 1);
break;
case IRQ_TYPE_LEVEL_LOW:
sprd_eic_update(chip, offset, SPRD_EIC_LATCH_INTPOL, 1);
+ sprd_eic_update(chip, offset, SPRD_EIC_LATCH_INTCLR, 1);
break;
case IRQ_TYPE_EDGE_RISING:
case IRQ_TYPE_EDGE_FALLING:
case IRQ_TYPE_EDGE_BOTH:
state = sprd_eic_get(chip, offset);
- if (state)
+ if (state) {
sprd_eic_update(chip, offset,
SPRD_EIC_LATCH_INTPOL, 0);
- else
+ sprd_eic_update(chip, offset,
+ SPRD_EIC_LATCH_INTCLR, 1);
+ } else {
sprd_eic_update(chip, offset,
SPRD_EIC_LATCH_INTPOL, 1);
+ sprd_eic_update(chip, offset,
+ SPRD_EIC_LATCH_INTCLR, 1);
+ }
break;
default:
return -ENOTSUPP;
@@ -382,29 +396,34 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 1);
+ sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
irq_set_handler_locked(data, handle_edge_irq);
break;
case IRQ_TYPE_EDGE_FALLING:
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 0);
+ sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
irq_set_handler_locked(data, handle_edge_irq);
break;
case IRQ_TYPE_EDGE_BOTH:
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 1);
+ sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
irq_set_handler_locked(data, handle_edge_irq);
break;
case IRQ_TYPE_LEVEL_HIGH:
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 1);
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 1);
+ sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
irq_set_handler_locked(data, handle_level_irq);
break;
case IRQ_TYPE_LEVEL_LOW:
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 1);
sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 0);
+ sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
irq_set_handler_locked(data, handle_level_irq);
break;
default:
@@ -417,29 +436,34 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 1);
+ sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
irq_set_handler_locked(data, handle_edge_irq);
break;
case IRQ_TYPE_EDGE_FALLING:
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 0);
+ sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
irq_set_handler_locked(data, handle_edge_irq);
break;
case IRQ_TYPE_EDGE_BOTH:
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 1);
+ sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
irq_set_handler_locked(data, handle_edge_irq);
break;
case IRQ_TYPE_LEVEL_HIGH:
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 1);
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 1);
+ sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
irq_set_handler_locked(data, handle_level_irq);
break;
case IRQ_TYPE_LEVEL_LOW:
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 1);
sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 0);
+ sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
irq_set_handler_locked(data, handle_level_irq);
break;
default:
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH V4 2/2] gpio: eic-sprd: Optimize the calculation method of eic number
2024-01-09 7:38 [PATCH V4 0/2] gpio: sprd: Modification of UNISOC Platform EIC Driver Wenhua Lin
2024-01-09 7:38 ` [PATCH V4 1/2] gpio: eic-sprd: Clear interrupt after set the interrupt type Wenhua Lin
@ 2024-01-09 7:38 ` Wenhua Lin
2024-01-22 10:02 ` Chunyan Zhang
2024-01-22 9:33 ` [PATCH V4 0/2] gpio: sprd: Modification of UNISOC Platform EIC Driver Bartosz Golaszewski
2024-01-22 10:42 ` Bartosz Golaszewski
3 siblings, 1 reply; 7+ messages in thread
From: Wenhua Lin @ 2024-01-09 7:38 UTC (permalink / raw)
To: Linus Walleij, Andy Shevchenko, Bartosz Golaszewski
Cc: Orson Zhai, Baolin Wang, Chunyan Zhang, linux-gpio, linux-kernel,
wenhua lin, Wenhua Lin, Xiongpeng Wu
The num_eics is a default value, but some SoCs support more than 8.
In order to adapt to all projects, the total number of eics is
automatically calculated through dts.
Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
---
drivers/gpio/gpio-eic-sprd.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
index 806b88d8dfb7..2dd0e46c42ad 100644
--- a/drivers/gpio/gpio-eic-sprd.c
+++ b/drivers/gpio/gpio-eic-sprd.c
@@ -108,7 +108,6 @@ static struct sprd_eic *to_sprd_eic(struct notifier_block *nb)
struct sprd_eic_variant_data {
enum sprd_eic_type type;
- u32 num_eics;
};
static const char *sprd_eic_label_name[SPRD_EIC_MAX] = {
@@ -118,22 +117,18 @@ static const char *sprd_eic_label_name[SPRD_EIC_MAX] = {
static const struct sprd_eic_variant_data sc9860_eic_dbnc_data = {
.type = SPRD_EIC_DEBOUNCE,
- .num_eics = 8,
};
static const struct sprd_eic_variant_data sc9860_eic_latch_data = {
.type = SPRD_EIC_LATCH,
- .num_eics = 8,
};
static const struct sprd_eic_variant_data sc9860_eic_async_data = {
.type = SPRD_EIC_ASYNC,
- .num_eics = 8,
};
static const struct sprd_eic_variant_data sc9860_eic_sync_data = {
.type = SPRD_EIC_SYNC,
- .num_eics = 8,
};
static inline void __iomem *sprd_eic_offset_base(struct sprd_eic *sprd_eic,
@@ -619,6 +614,7 @@ static int sprd_eic_probe(struct platform_device *pdev)
struct gpio_irq_chip *irq;
struct sprd_eic *sprd_eic;
struct resource *res;
+ u16 num_banks = 0;
int ret, i;
pdata = of_device_get_match_data(dev);
@@ -652,10 +648,12 @@ static int sprd_eic_probe(struct platform_device *pdev)
sprd_eic->base[i] = devm_ioremap_resource(dev, res);
if (IS_ERR(sprd_eic->base[i]))
return PTR_ERR(sprd_eic->base[i]);
+
+ num_banks++;
}
sprd_eic->chip.label = sprd_eic_label_name[sprd_eic->type];
- sprd_eic->chip.ngpio = pdata->num_eics;
+ sprd_eic->chip.ngpio = num_banks * SPRD_EIC_PER_BANK_NR;
sprd_eic->chip.base = -1;
sprd_eic->chip.parent = dev;
sprd_eic->chip.direction_input = sprd_eic_direction_input;
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH V4 0/2] gpio: sprd: Modification of UNISOC Platform EIC Driver
2024-01-09 7:38 [PATCH V4 0/2] gpio: sprd: Modification of UNISOC Platform EIC Driver Wenhua Lin
2024-01-09 7:38 ` [PATCH V4 1/2] gpio: eic-sprd: Clear interrupt after set the interrupt type Wenhua Lin
2024-01-09 7:38 ` [PATCH V4 2/2] gpio: eic-sprd: Optimize the calculation method of eic number Wenhua Lin
@ 2024-01-22 9:33 ` Bartosz Golaszewski
2024-01-22 10:42 ` Bartosz Golaszewski
3 siblings, 0 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2024-01-22 9:33 UTC (permalink / raw)
To: Wenhua Lin
Cc: Linus Walleij, Andy Shevchenko, Orson Zhai, Baolin Wang,
Chunyan Zhang, linux-gpio, linux-kernel, wenhua lin, Xiongpeng Wu
On Tue, Jan 9, 2024 at 8:39 AM Wenhua Lin <Wenhua.Lin@unisoc.com> wrote:
>
> Recently, some bugs have been discovered during use, and patch1
> are bug fixes. Also, this patchset add optimization:
> patch2 optimization the calculation method of eic number.
>
> Change in V4:
>
> -Add Fixes tag in PATCH 1/2.
> -Change commit message in PATCH 1/2.
> -Add clearing interrupt to debounce and latch mode in PATCH 1/2.
>
> -Change commit message in PATCH 2/2.
> -Delete SPRD_EIC_VAR_DATA macro in PATCH 2/2.
>
> Wenhua Lin (2):
> gpio: eic-sprd: Clear interrupt after set the interrupt type
> gpio: eic-sprd: Optimize the calculation method of eic number
>
> drivers/gpio/gpio-eic-sprd.c | 42 +++++++++++++++++++++++++++---------
> 1 file changed, 32 insertions(+), 10 deletions(-)
>
> --
> 2.17.1
>
>
Hey,
Can we get an Ack and (preferably) a Tested-by from the SPRD
maintainers, please?
Bart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V4 1/2] gpio: eic-sprd: Clear interrupt after set the interrupt type
2024-01-09 7:38 ` [PATCH V4 1/2] gpio: eic-sprd: Clear interrupt after set the interrupt type Wenhua Lin
@ 2024-01-22 10:00 ` Chunyan Zhang
0 siblings, 0 replies; 7+ messages in thread
From: Chunyan Zhang @ 2024-01-22 10:00 UTC (permalink / raw)
To: Wenhua Lin
Cc: Linus Walleij, Andy Shevchenko, Bartosz Golaszewski, Orson Zhai,
Baolin Wang, linux-gpio, linux-kernel, wenhua lin, Xiongpeng Wu
On Tue, 9 Jan 2024 at 15:39, Wenhua Lin <Wenhua.Lin@unisoc.com> wrote:
>
> The raw interrupt status of eic maybe set before the interrupt is enabled,
> since the eic interrupt has a latch function, which would trigger the
> interrupt event once enabled it from user side. To solve this problem,
> interrupts generated before setting the interrupt trigger type are ignored.
>
> Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
> ---
> drivers/gpio/gpio-eic-sprd.c | 32 ++++++++++++++++++++++++++++----
> 1 file changed, 28 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
> index be7f2fa5aa7b..806b88d8dfb7 100644
> --- a/drivers/gpio/gpio-eic-sprd.c
> +++ b/drivers/gpio/gpio-eic-sprd.c
> @@ -330,20 +330,27 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
> switch (flow_type) {
> case IRQ_TYPE_LEVEL_HIGH:
> sprd_eic_update(chip, offset, SPRD_EIC_DBNC_IEV, 1);
> + sprd_eic_update(chip, offset, SPRD_EIC_DBNC_IC, 1);
> break;
> case IRQ_TYPE_LEVEL_LOW:
> sprd_eic_update(chip, offset, SPRD_EIC_DBNC_IEV, 0);
> + sprd_eic_update(chip, offset, SPRD_EIC_DBNC_IC, 1);
> break;
> case IRQ_TYPE_EDGE_RISING:
> case IRQ_TYPE_EDGE_FALLING:
> case IRQ_TYPE_EDGE_BOTH:
> state = sprd_eic_get(chip, offset);
> - if (state)
> + if (state) {
> sprd_eic_update(chip, offset,
> SPRD_EIC_DBNC_IEV, 0);
> - else
> + sprd_eic_update(chip, offset,
> + SPRD_EIC_DBNC_IC, 1);
> + } else {
> sprd_eic_update(chip, offset,
> SPRD_EIC_DBNC_IEV, 1);
> + sprd_eic_update(chip, offset,
> + SPRD_EIC_DBNC_IC, 1);
> + }
> break;
> default:
> return -ENOTSUPP;
> @@ -355,20 +362,27 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
> switch (flow_type) {
> case IRQ_TYPE_LEVEL_HIGH:
> sprd_eic_update(chip, offset, SPRD_EIC_LATCH_INTPOL, 0);
> + sprd_eic_update(chip, offset, SPRD_EIC_LATCH_INTCLR, 1);
> break;
> case IRQ_TYPE_LEVEL_LOW:
> sprd_eic_update(chip, offset, SPRD_EIC_LATCH_INTPOL, 1);
> + sprd_eic_update(chip, offset, SPRD_EIC_LATCH_INTCLR, 1);
> break;
> case IRQ_TYPE_EDGE_RISING:
> case IRQ_TYPE_EDGE_FALLING:
> case IRQ_TYPE_EDGE_BOTH:
> state = sprd_eic_get(chip, offset);
> - if (state)
> + if (state) {
> sprd_eic_update(chip, offset,
> SPRD_EIC_LATCH_INTPOL, 0);
> - else
> + sprd_eic_update(chip, offset,
> + SPRD_EIC_LATCH_INTCLR, 1);
> + } else {
> sprd_eic_update(chip, offset,
> SPRD_EIC_LATCH_INTPOL, 1);
> + sprd_eic_update(chip, offset,
> + SPRD_EIC_LATCH_INTCLR, 1);
> + }
> break;
> default:
> return -ENOTSUPP;
> @@ -382,29 +396,34 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 1);
> + sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
> irq_set_handler_locked(data, handle_edge_irq);
> break;
> case IRQ_TYPE_EDGE_FALLING:
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 0);
> + sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
> irq_set_handler_locked(data, handle_edge_irq);
> break;
> case IRQ_TYPE_EDGE_BOTH:
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 1);
> + sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
> irq_set_handler_locked(data, handle_edge_irq);
> break;
> case IRQ_TYPE_LEVEL_HIGH:
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 1);
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 1);
> + sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
> irq_set_handler_locked(data, handle_level_irq);
> break;
> case IRQ_TYPE_LEVEL_LOW:
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTBOTH, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTMODE, 1);
> sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTPOL, 0);
> + sprd_eic_update(chip, offset, SPRD_EIC_ASYNC_INTCLR, 1);
> irq_set_handler_locked(data, handle_level_irq);
> break;
> default:
> @@ -417,29 +436,34 @@ static int sprd_eic_irq_set_type(struct irq_data *data, unsigned int flow_type)
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 1);
> + sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
> irq_set_handler_locked(data, handle_edge_irq);
> break;
> case IRQ_TYPE_EDGE_FALLING:
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 0);
> + sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
> irq_set_handler_locked(data, handle_edge_irq);
> break;
> case IRQ_TYPE_EDGE_BOTH:
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 1);
> + sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
> irq_set_handler_locked(data, handle_edge_irq);
> break;
> case IRQ_TYPE_LEVEL_HIGH:
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 1);
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 1);
> + sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
> irq_set_handler_locked(data, handle_level_irq);
> break;
> case IRQ_TYPE_LEVEL_LOW:
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTBOTH, 0);
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTMODE, 1);
> sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTPOL, 0);
> + sprd_eic_update(chip, offset, SPRD_EIC_SYNC_INTCLR, 1);
> irq_set_handler_locked(data, handle_level_irq);
> break;
> default:
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V4 2/2] gpio: eic-sprd: Optimize the calculation method of eic number
2024-01-09 7:38 ` [PATCH V4 2/2] gpio: eic-sprd: Optimize the calculation method of eic number Wenhua Lin
@ 2024-01-22 10:02 ` Chunyan Zhang
0 siblings, 0 replies; 7+ messages in thread
From: Chunyan Zhang @ 2024-01-22 10:02 UTC (permalink / raw)
To: Wenhua Lin
Cc: Linus Walleij, Andy Shevchenko, Bartosz Golaszewski, Orson Zhai,
Baolin Wang, linux-gpio, linux-kernel, wenhua lin, Xiongpeng Wu
On Tue, 9 Jan 2024 at 15:39, Wenhua Lin <Wenhua.Lin@unisoc.com> wrote:
>
> The num_eics is a default value, but some SoCs support more than 8.
> In order to adapt to all projects, the total number of eics is
> automatically calculated through dts.
>
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
Thanks,
Chunyan
> ---
> drivers/gpio/gpio-eic-sprd.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
> index 806b88d8dfb7..2dd0e46c42ad 100644
> --- a/drivers/gpio/gpio-eic-sprd.c
> +++ b/drivers/gpio/gpio-eic-sprd.c
> @@ -108,7 +108,6 @@ static struct sprd_eic *to_sprd_eic(struct notifier_block *nb)
>
> struct sprd_eic_variant_data {
> enum sprd_eic_type type;
> - u32 num_eics;
> };
>
> static const char *sprd_eic_label_name[SPRD_EIC_MAX] = {
> @@ -118,22 +117,18 @@ static const char *sprd_eic_label_name[SPRD_EIC_MAX] = {
>
> static const struct sprd_eic_variant_data sc9860_eic_dbnc_data = {
> .type = SPRD_EIC_DEBOUNCE,
> - .num_eics = 8,
> };
>
> static const struct sprd_eic_variant_data sc9860_eic_latch_data = {
> .type = SPRD_EIC_LATCH,
> - .num_eics = 8,
> };
>
> static const struct sprd_eic_variant_data sc9860_eic_async_data = {
> .type = SPRD_EIC_ASYNC,
> - .num_eics = 8,
> };
>
> static const struct sprd_eic_variant_data sc9860_eic_sync_data = {
> .type = SPRD_EIC_SYNC,
> - .num_eics = 8,
> };
>
> static inline void __iomem *sprd_eic_offset_base(struct sprd_eic *sprd_eic,
> @@ -619,6 +614,7 @@ static int sprd_eic_probe(struct platform_device *pdev)
> struct gpio_irq_chip *irq;
> struct sprd_eic *sprd_eic;
> struct resource *res;
> + u16 num_banks = 0;
> int ret, i;
>
> pdata = of_device_get_match_data(dev);
> @@ -652,10 +648,12 @@ static int sprd_eic_probe(struct platform_device *pdev)
> sprd_eic->base[i] = devm_ioremap_resource(dev, res);
> if (IS_ERR(sprd_eic->base[i]))
> return PTR_ERR(sprd_eic->base[i]);
> +
> + num_banks++;
> }
>
> sprd_eic->chip.label = sprd_eic_label_name[sprd_eic->type];
> - sprd_eic->chip.ngpio = pdata->num_eics;
> + sprd_eic->chip.ngpio = num_banks * SPRD_EIC_PER_BANK_NR;
> sprd_eic->chip.base = -1;
> sprd_eic->chip.parent = dev;
> sprd_eic->chip.direction_input = sprd_eic_direction_input;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V4 0/2] gpio: sprd: Modification of UNISOC Platform EIC Driver
2024-01-09 7:38 [PATCH V4 0/2] gpio: sprd: Modification of UNISOC Platform EIC Driver Wenhua Lin
` (2 preceding siblings ...)
2024-01-22 9:33 ` [PATCH V4 0/2] gpio: sprd: Modification of UNISOC Platform EIC Driver Bartosz Golaszewski
@ 2024-01-22 10:42 ` Bartosz Golaszewski
3 siblings, 0 replies; 7+ messages in thread
From: Bartosz Golaszewski @ 2024-01-22 10:42 UTC (permalink / raw)
To: Wenhua Lin
Cc: Linus Walleij, Andy Shevchenko, Orson Zhai, Baolin Wang,
Chunyan Zhang, linux-gpio, linux-kernel, wenhua lin, Xiongpeng Wu
On Tue, Jan 9, 2024 at 8:39 AM Wenhua Lin <Wenhua.Lin@unisoc.com> wrote:
>
> Recently, some bugs have been discovered during use, and patch1
> are bug fixes. Also, this patchset add optimization:
> patch2 optimization the calculation method of eic number.
>
> Change in V4:
>
> -Add Fixes tag in PATCH 1/2.
> -Change commit message in PATCH 1/2.
> -Add clearing interrupt to debounce and latch mode in PATCH 1/2.
>
> -Change commit message in PATCH 2/2.
> -Delete SPRD_EIC_VAR_DATA macro in PATCH 2/2.
>
> Wenhua Lin (2):
> gpio: eic-sprd: Clear interrupt after set the interrupt type
> gpio: eic-sprd: Optimize the calculation method of eic number
>
> drivers/gpio/gpio-eic-sprd.c | 42 +++++++++++++++++++++++++++---------
> 1 file changed, 32 insertions(+), 10 deletions(-)
>
> --
> 2.17.1
>
>
Applied with Acks from Chunyan.
Bartosz
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-22 10:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-09 7:38 [PATCH V4 0/2] gpio: sprd: Modification of UNISOC Platform EIC Driver Wenhua Lin
2024-01-09 7:38 ` [PATCH V4 1/2] gpio: eic-sprd: Clear interrupt after set the interrupt type Wenhua Lin
2024-01-22 10:00 ` Chunyan Zhang
2024-01-09 7:38 ` [PATCH V4 2/2] gpio: eic-sprd: Optimize the calculation method of eic number Wenhua Lin
2024-01-22 10:02 ` Chunyan Zhang
2024-01-22 9:33 ` [PATCH V4 0/2] gpio: sprd: Modification of UNISOC Platform EIC Driver Bartosz Golaszewski
2024-01-22 10:42 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).