From: Huacai Chen <chenhuacai@kernel.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>
Cc: Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Yinbo Zhu <zhuyinbo@loongson.cn>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, linux-gpio@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] gpio: loongson-64bit: Correct Loongson-7A2000 ACPI GPIO access mode
Date: Tue, 10 Jun 2025 20:02:56 +0800 [thread overview]
Message-ID: <CAAhV-H5Aq=GoJpY6KH9FQX_RcPfx0D9XUtjjVf=ZfxEdhj93mQ@mail.gmail.com> (raw)
In-Reply-To: <20250610115926.347845-1-zhoubinbin@loongson.cn>
Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
On Tue, Jun 10, 2025 at 7:59 PM Binbin Zhou <zhoubinbin@loongson.cn> wrote:
>
> According to the description of the Loongson-7A2000 ACPI GPIO register in
> the manual, its access mode should be BIT_CTRL_MODE, otherwise there maybe
> some unpredictable behavior.
>
> Cc: stable@vger.kernel.org
> Fixes: 44fe79020b91 ("gpio: loongson-64bit: Add more gpio chip support")
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
> drivers/gpio/gpio-loongson-64bit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-loongson-64bit.c b/drivers/gpio/gpio-loongson-64bit.c
> index 26227669f026..70a01c5b8ad1 100644
> --- a/drivers/gpio/gpio-loongson-64bit.c
> +++ b/drivers/gpio/gpio-loongson-64bit.c
> @@ -268,7 +268,7 @@ static const struct loongson_gpio_chip_data loongson_gpio_ls7a2000_data0 = {
> /* LS7A2000 ACPI GPIO */
> static const struct loongson_gpio_chip_data loongson_gpio_ls7a2000_data1 = {
> .label = "ls7a2000_gpio",
> - .mode = BYTE_CTRL_MODE,
> + .mode = BIT_CTRL_MODE,
> .conf_offset = 0x4,
> .in_offset = 0x8,
> .out_offset = 0x0,
>
> base-commit: e0d4a0f1d066f14522049e827107a577444d9183
> --
> 2.47.1
>
next prev parent reply other threads:[~2025-06-10 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 11:59 [PATCH] gpio: loongson-64bit: Correct Loongson-7A2000 ACPI GPIO access mode Binbin Zhou
2025-06-10 12:02 ` Huacai Chen [this message]
2025-06-11 12:33 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAhV-H5Aq=GoJpY6KH9FQX_RcPfx0D9XUtjjVf=ZfxEdhj93mQ@mail.gmail.com' \
--to=chenhuacai@kernel.org \
--cc=brgl@bgdev.pl \
--cc=chenhuacai@loongson.cn \
--cc=kernel@xen0n.name \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).