* [PATCH] gpio: loongson-64bit: Correct Loongson-7A2000 ACPI GPIO access mode
@ 2025-06-10 11:59 Binbin Zhou
2025-06-10 12:02 ` Huacai Chen
2025-06-11 12:33 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Binbin Zhou @ 2025-06-10 11:59 UTC (permalink / raw)
To: Binbin Zhou, Huacai Chen, Yinbo Zhu, Linus Walleij,
Bartosz Golaszewski
Cc: Huacai Chen, Xuerui Wang, loongarch, linux-gpio, Binbin Zhou,
stable
According to the description of the Loongson-7A2000 ACPI GPIO register in
the manual, its access mode should be BIT_CTRL_MODE, otherwise there maybe
some unpredictable behavior.
Cc: stable@vger.kernel.org
Fixes: 44fe79020b91 ("gpio: loongson-64bit: Add more gpio chip support")
Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
---
drivers/gpio/gpio-loongson-64bit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-loongson-64bit.c b/drivers/gpio/gpio-loongson-64bit.c
index 26227669f026..70a01c5b8ad1 100644
--- a/drivers/gpio/gpio-loongson-64bit.c
+++ b/drivers/gpio/gpio-loongson-64bit.c
@@ -268,7 +268,7 @@ static const struct loongson_gpio_chip_data loongson_gpio_ls7a2000_data0 = {
/* LS7A2000 ACPI GPIO */
static const struct loongson_gpio_chip_data loongson_gpio_ls7a2000_data1 = {
.label = "ls7a2000_gpio",
- .mode = BYTE_CTRL_MODE,
+ .mode = BIT_CTRL_MODE,
.conf_offset = 0x4,
.in_offset = 0x8,
.out_offset = 0x0,
base-commit: e0d4a0f1d066f14522049e827107a577444d9183
--
2.47.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: loongson-64bit: Correct Loongson-7A2000 ACPI GPIO access mode
2025-06-10 11:59 [PATCH] gpio: loongson-64bit: Correct Loongson-7A2000 ACPI GPIO access mode Binbin Zhou
@ 2025-06-10 12:02 ` Huacai Chen
2025-06-11 12:33 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Huacai Chen @ 2025-06-10 12:02 UTC (permalink / raw)
To: Binbin Zhou
Cc: Binbin Zhou, Huacai Chen, Yinbo Zhu, Linus Walleij,
Bartosz Golaszewski, Xuerui Wang, loongarch, linux-gpio, stable
Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
On Tue, Jun 10, 2025 at 7:59 PM Binbin Zhou <zhoubinbin@loongson.cn> wrote:
>
> According to the description of the Loongson-7A2000 ACPI GPIO register in
> the manual, its access mode should be BIT_CTRL_MODE, otherwise there maybe
> some unpredictable behavior.
>
> Cc: stable@vger.kernel.org
> Fixes: 44fe79020b91 ("gpio: loongson-64bit: Add more gpio chip support")
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
> drivers/gpio/gpio-loongson-64bit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-loongson-64bit.c b/drivers/gpio/gpio-loongson-64bit.c
> index 26227669f026..70a01c5b8ad1 100644
> --- a/drivers/gpio/gpio-loongson-64bit.c
> +++ b/drivers/gpio/gpio-loongson-64bit.c
> @@ -268,7 +268,7 @@ static const struct loongson_gpio_chip_data loongson_gpio_ls7a2000_data0 = {
> /* LS7A2000 ACPI GPIO */
> static const struct loongson_gpio_chip_data loongson_gpio_ls7a2000_data1 = {
> .label = "ls7a2000_gpio",
> - .mode = BYTE_CTRL_MODE,
> + .mode = BIT_CTRL_MODE,
> .conf_offset = 0x4,
> .in_offset = 0x8,
> .out_offset = 0x0,
>
> base-commit: e0d4a0f1d066f14522049e827107a577444d9183
> --
> 2.47.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: loongson-64bit: Correct Loongson-7A2000 ACPI GPIO access mode
2025-06-10 11:59 [PATCH] gpio: loongson-64bit: Correct Loongson-7A2000 ACPI GPIO access mode Binbin Zhou
2025-06-10 12:02 ` Huacai Chen
@ 2025-06-11 12:33 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2025-06-11 12:33 UTC (permalink / raw)
To: Binbin Zhou, Yinbo Zhu, Linus Walleij, Bartosz Golaszewski,
Huacai Chen, Binbin Zhou
Cc: Bartosz Golaszewski, Xuerui Wang, loongarch, linux-gpio, stable
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Tue, 10 Jun 2025 19:59:26 +0800, Binbin Zhou wrote:
> According to the description of the Loongson-7A2000 ACPI GPIO register in
> the manual, its access mode should be BIT_CTRL_MODE, otherwise there maybe
> some unpredictable behavior.
>
>
Applied, thanks!
[1/1] gpio: loongson-64bit: Correct Loongson-7A2000 ACPI GPIO access mode
https://git.kernel.org/brgl/linux/c/72f37957007d25f4290e3ba40d40aaec1dd0b0cf
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-11 12:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-10 11:59 [PATCH] gpio: loongson-64bit: Correct Loongson-7A2000 ACPI GPIO access mode Binbin Zhou
2025-06-10 12:02 ` Huacai Chen
2025-06-11 12:33 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).