From: Javier Martinez Canillas <javier@dowhile0.org>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Linux GPIO List <linux-gpio@vger.kernel.org>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>
Subject: Re: [PATCH] gpio: mvebu: Remove initcall-based driver initialization
Date: Fri, 25 Apr 2014 12:01:58 +0200 [thread overview]
Message-ID: <CABxcv=nDCJXpnn2JSPZ3b64srpFkzuGyUkVS=ivp-qx_fXxzOQ@mail.gmail.com> (raw)
In-Reply-To: <1398372890-7568-1-git-send-email-ezequiel.garcia@free-electrons.com>
Hello Ezequiel,
On Thu, Apr 24, 2014 at 10:54 PM, Ezequiel Garcia
<ezequiel.garcia@free-electrons.com> wrote:
> There's no reason to use an initcall to initialize this driver,
> and regular module_platform_driver() can be used instead.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
> drivers/gpio/gpio-mvebu.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index d425094..7d64cde 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -738,9 +738,4 @@ static struct platform_driver mvebu_gpio_driver = {
> },
> .probe = mvebu_gpio_probe,
> };
> -
> -static int __init mvebu_gpio_init(void)
> -{
> - return platform_driver_register(&mvebu_gpio_driver);
> -}
> -postcore_initcall(mvebu_gpio_init);
> +module_platform_driver(mvebu_gpio_driver);
> --
> 1.9.1
>
> --
Looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@dowhile0.org>
next prev parent reply other threads:[~2014-04-25 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 20:54 [PATCH] gpio: mvebu: Remove initcall-based driver initialization Ezequiel Garcia
2014-04-25 10:01 ` Javier Martinez Canillas [this message]
2014-04-29 13:23 ` Jason Cooper
2014-05-09 9:09 ` Linus Walleij
2014-05-09 13:08 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABxcv=nDCJXpnn2JSPZ3b64srpFkzuGyUkVS=ivp-qx_fXxzOQ@mail.gmail.com' \
--to=javier@dowhile0.org \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).