[PATCH] gpio: mvebu: Remove initcall-based driver initialization

[PATCH] gpio: mvebu: Remove initcall-based driver initialization

[Ezequiel Garcia]

There's no reason to use an initcall to initialize this driver,
and regular module_platform_driver() can be used instead.

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 drivers/gpio/gpio-mvebu.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index d425094..7d64cde 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -738,9 +738,4 @@ static struct platform_driver mvebu_gpio_driver = {
 	},
 	.probe		= mvebu_gpio_probe,
 };
-
-static int __init mvebu_gpio_init(void)
-{
-	return platform_driver_register(&mvebu_gpio_driver);
-}
-postcore_initcall(mvebu_gpio_init);
+module_platform_driver(mvebu_gpio_driver);
-- 
1.9.1

Re: [PATCH] gpio: mvebu: Remove initcall-based driver initialization

[Javier Martinez Canillas]

Hello Ezequiel,

On Thu, Apr 24, 2014 at 10:54 PM, Ezequiel Garcia
<ezequiel.garcia@free-electrons.com> wrote:
> There's no reason to use an initcall to initialize this driver,
> and regular module_platform_driver() can be used instead.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
>  drivers/gpio/gpio-mvebu.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index d425094..7d64cde 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -738,9 +738,4 @@ static struct platform_driver mvebu_gpio_driver = {
>         },
>         .probe          = mvebu_gpio_probe,
>  };
> -
> -static int __init mvebu_gpio_init(void)
> -{
> -       return platform_driver_register(&mvebu_gpio_driver);
> -}
> -postcore_initcall(mvebu_gpio_init);
> +module_platform_driver(mvebu_gpio_driver);
> --
> 1.9.1
>
> --

Looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@dowhile0.org>

Re: [PATCH] gpio: mvebu: Remove initcall-based driver initialization

[Jason Cooper]

On Thu, Apr 24, 2014 at 05:54:50PM -0300, Ezequiel Garcia wrote:
> There's no reason to use an initcall to initialize this driver,
> and regular module_platform_driver() can be used instead.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
>  drivers/gpio/gpio-mvebu.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Acked-by: Jason Cooper <jason@lakedaemon.net>

thx,

Jason.

Re: [PATCH] gpio: mvebu: Remove initcall-based driver initialization

[Linus Walleij]

On Thu, Apr 24, 2014 at 10:54 PM, Ezequiel Garcia
<ezequiel.garcia@free-electrons.com> wrote:

> There's no reason to use an initcall to initialize this driver,
> and regular module_platform_driver() can be used instead.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

Has anyone tested this on real hardware? That is the only test that
counts on initcalls as it happens.

That said, patch is tentatively applied as I guess you have the hardware.

Yours,
Linus Walleij

Re: [PATCH] gpio: mvebu: Remove initcall-based driver initialization

[Ezequiel Garcia]

On 09 May 11:09 AM, Linus Walleij wrote:
> On Thu, Apr 24, 2014 at 10:54 PM, Ezequiel Garcia
> <ezequiel.garcia@free-electrons.com> wrote:
> 
> > There's no reason to use an initcall to initialize this driver,
> > and regular module_platform_driver() can be used instead.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> 
> Has anyone tested this on real hardware? That is the only test that
> counts on initcalls as it happens.
> 

Yup, tested on my mvebu boards, don't remember which one.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html