From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D104723A9A8 for ; Tue, 6 May 2025 17:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746551909; cv=none; b=nJ6O+FSB/Dfp3i6gZvmyu7kCz+/5P9FV5Ywedl8vrOL+iz7tF04tkHdzk8t2Hm4VQMZmRRtG/G7u/1ylc6cewUV3fGn8FhAbcFKmbqBWSSbOpX1D/B4fTphgexDpTWgKXcVsvfQMjKekJsXrD9oe/3VmieIqKvcQhKRoWvVm9Zc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746551909; c=relaxed/simple; bh=OQYAgODVpINZnz+yw7v2ECzJe/sFXzngEsMGegGS4oE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=lXdRlYs0drQsOAUwc9425yQ61ev4q4skXvSJRqZamsh+JpzA0cmasVITqrzmdjHBKDbeGCoFFqSqGUDY7rMdDiTG9A+gMOluzFAeUEdJ2yJhcA3XgvwvUVo78UIu0L1acl8MveMtyfJQhc6wZPl7kwpfA3QcOjDj2lzB2N47ShM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OCLDHUw+; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OCLDHUw+" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-ac25d2b2354so897442766b.1 for ; Tue, 06 May 2025 10:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746551906; x=1747156706; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hLpQQKNN/MIjkhEPtNp036EW9veXKKXnE5G67+atsR4=; b=OCLDHUw+8L40u0CJlZbpAxVl9DYET0jNIGuxSJm0gUCsB9Vjg1ThdwLxDMVsD6M8/W /AwUGW1od2bj5aFws+tzzLlOf+HFEt4bHger8BRDEscjD/3CGRE3TrR2a4wrzOKuQgQ2 xPFrO3vChHWVmAhy+IXhZQkw8SBUcBIEXd9P1ubs5zFFR84tR3TXUOUYN2KFiWalOJdS Zf/SlpbAWXQtSVOWHS9pDGOHvxlZcNVqPRLPXSjZuZFbBQYPtvyd9F5ivMNo6jUoaIVM 4si5HyJxSeDQySlZkANVQHtS3tNCaXlyU+nt6/AhhE44BWesu3FgOYl4ijKBMwPDW+SX 6A3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746551906; x=1747156706; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hLpQQKNN/MIjkhEPtNp036EW9veXKKXnE5G67+atsR4=; b=Elc5JXEkTvLC1vi9QKdjlynYYz+vJswIQ94pjoRO3Hv4wImjhJm7voUbmnK9WXrcX6 J85WDn+zYT4U6SWjUroCaGK6DaafsFWo8P+nIqCIROf99Oj3t+aho5DkXTuu/9kXPJ6s HxnCfNkuOrrH/1ZG5nxlDJJIEfhoZ7MuDn5KlooC5zJ9HvzBmvG0WqifmcFp+IwlJQRb nZLG2bcH/hvyfqZvfYKQ2xgw4ItB5YS8nHymUbu5TRpfkyom31YWfdHKQXZIYpGLcTXU 40ZaFFV+5f/ImYvfrX/vzgc46fdhfz1PlZw7G2Mk4m78zB6UUWTPr9KyovzRC85fQ3nU CetA== X-Forwarded-Encrypted: i=1; AJvYcCXA9taCLEQtAJqZZcaKU5PNJWneXgVO8aq0k5xI826jMA3TtawDRytD2SDqZCa3cFCsNc1UHUL32zyJ@vger.kernel.org X-Gm-Message-State: AOJu0YyKHvie2NGnLOis61EUjlgARgjOLveb+8XnM8Zh4Gb6jJb/lP8n IR38lrj9nl+JRCdRG26CTv7zm3l8CLJBuxUFbgbJ/phIJs8TIjH4+z/geoJIhc/BS6l6esohJVp /osI4cM3LSj5Rhm/kXtqSnMPCY/P8Ln9fGoWSCQ== X-Gm-Gg: ASbGnctovX3r+CbGZb0rHFfAazrMCv+2HUDLfGhn7NbC+OFDgXjOFvfae8w+8npFQAm xacX5MLM8miMR78NY3IKuNZs4GIp40ojPJSTitUXr0cZdZ1oCax/LPAzBjazcnxrPq2331RSF+P 08rtAIZUF2oE0tXchUHndgigFqWyVcan+WJYcqIj40mE2nkjND3tnK5A== X-Google-Smtp-Source: AGHT+IHE66Vgpa971cMKK+duyPRa6SkPlWJvDTybSqVOU3NLmgHpf+zEI6gVYKmySXbRn89yPrqAvZDICOtPIeFmSJE= X-Received: by 2002:a17:907:720a:b0:acb:b900:2bca with SMTP id a640c23a62f3a-ad1e8a03c6dmr34414766b.0.1746551905998; Tue, 06 May 2025 10:18:25 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250503-pinctrl-msm-fix-v1-0-da9b7f6408f4@oss.qualcomm.com> <20250503-pinctrl-msm-fix-v1-3-da9b7f6408f4@oss.qualcomm.com> In-Reply-To: <20250503-pinctrl-msm-fix-v1-3-da9b7f6408f4@oss.qualcomm.com> From: Bartosz Golaszewski Date: Tue, 6 May 2025 19:18:15 +0200 X-Gm-Features: ATxdqUGWZrl5YOiP7Og6r3-nl2H9A1mVWnPA1IqXnDAC-_8SNMX6_toeynsOt7M Message-ID: Subject: Re: [PATCH 3/4] pinctrl: qcom: switch to devm_gpiochip_add_data() To: Dmitry Baryshkov Cc: Bjorn Andersson , Linus Walleij , Guenter Roeck , Josh Cartwright , Matti Vaittinen , Doug Anderson , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Sat, 3 May 2025 at 07:32, Dmitry Baryshkov wrote: > > In order to simplify cleanup actions, use devres-enabled version of > gpiochip_add_data(). > > Signed-off-by: Dmitry Baryshkov > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c > index 88dd462516c76d58b43d49accbddeea38af8f1ec..b2e8f7b3f3e3d5d232b2bd60e5cace62b21ffb03 100644 > --- a/drivers/pinctrl/qcom/pinctrl-msm.c > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c > @@ -1449,7 +1449,7 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) > girq->handler = handle_bad_irq; > girq->parents[0] = pctrl->irq; > > - ret = gpiochip_add_data(&pctrl->chip, pctrl); > + ret = devm_gpiochip_add_data(pctrl->dev, &pctrl->chip, pctrl); > if (ret) { > dev_err(pctrl->dev, "Failed register gpiochip\n"); > return ret; > @@ -1470,7 +1470,6 @@ static int msm_gpio_init(struct msm_pinctrl *pctrl) > dev_name(pctrl->dev), 0, 0, chip->ngpio); > if (ret) { > dev_err(pctrl->dev, "Failed to add pin range\n"); > - gpiochip_remove(&pctrl->chip); > return ret; > } > } > @@ -1608,9 +1607,6 @@ EXPORT_SYMBOL(msm_pinctrl_probe); > > void msm_pinctrl_remove(struct platform_device *pdev) > { > - struct msm_pinctrl *pctrl = platform_get_drvdata(pdev); > - > - gpiochip_remove(&pctrl->chip); > } > EXPORT_SYMBOL(msm_pinctrl_remove); > > > -- > 2.39.5 > If you're at it then why not remove this function here and the callback assignment throughout the pinctrl/qcom/ directory? Bart