linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
To: Kent Gibson <warthog618@gmail.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
	Khem Raj <raj.khem@gmail.com>,
	linux-gpio@vger.kernel.org
Subject: Re: [libgpiod][PATCH] bindings: cxx: Migrate C++ tests to use Catch2 v3
Date: Mon, 3 Jun 2024 14:46:55 +0200	[thread overview]
Message-ID: <CACMJSetksaXNmmUXHwq1cyZkVEKABU3sk6jMAELnWsWymwU6AQ@mail.gmail.com> (raw)
In-Reply-To: <20240603122411.GA104620@rigel>

On Mon, 3 Jun 2024 at 14:24, Kent Gibson <warthog618@gmail.com> wrote:
>
> On Mon, Jun 03, 2024 at 11:34:15AM +0200, Bartosz Golaszewski wrote:
> > On Fri, May 31, 2024 at 8:42 PM Khem Raj <raj.khem@gmail.com> wrote:
> > >
> > > Catch2 v3.x has API changes which needs to be addressed
> > > in the tests themselves, hence this changeset is to fix
> > > those.
> > >
> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > > Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > ---
> >
> > Thanks for doing this, I recently added it to my TODO. I slightly
> > modified the change - added a version requirement for catch2 to
> > configure.ac (>= 3.0).
> >
>
> The only issue I have with the patch is that Debian stable, and all the
> distros based on it, are still on v2, so building for them will now
> require backporting catch2 from Debian testing.
> Probably not a deal-breaker, but another hurdle to be jumped.
>
> Cheers,
> Kent.

That's alright. It's been 4 years since the release of catch2 v3.0.

Bart

  reply	other threads:[~2024-06-03 12:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-31 18:42 [libgpiod][PATCH] bindings: cxx: Migrate C++ tests to use Catch2 v3 Khem Raj
2024-06-03  9:34 ` Bartosz Golaszewski
2024-06-03 12:24   ` Kent Gibson
2024-06-03 12:46     ` Bartosz Golaszewski [this message]
2024-06-03  9:38 ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACMJSetksaXNmmUXHwq1cyZkVEKABU3sk6jMAELnWsWymwU6AQ@mail.gmail.com \
    --to=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=linux-gpio@vger.kernel.org \
    --cc=raj.khem@gmail.com \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).