* [PATCH] ARM: dts: nuvoton,wpcm450-supermicro-x9sci-ln4f: Add GPIO line names
@ 2022-11-01 10:29 Jonathan Neuschäfer
2022-11-02 22:52 ` Joel Stanley
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Neuschäfer @ 2022-11-01 10:29 UTC (permalink / raw)
To: openbmc, linux-gpio
Cc: Jonathan Neuschäfer, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
To make gpioinfo output more useful and enable gpiofind usage, add line
names for GPIOs where the function is known.
This patch follows the naming convention defined for OpenBMC, as much as
possible:
https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
.../nuvoton-wpcm450-supermicro-x9sci-ln4f.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
index 26fed97f8ff4a..d4472ffdac928 100644
--- a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
+++ b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
@@ -58,6 +58,24 @@ heartbeat {
};
};
+&gpio0 {
+ gpio-line-names =
+ /* 0 */ "", "host-reset-control-n", "", "", "", "", "", "",
+ /* 8 */ "", "", "", "", "power-chassis-control-n", "", "uid-button", "";
+};
+
+&gpio1 {
+ gpio-line-names =
+ /* 0 */ "", "", "", "", "led-heartbeat", "", "", "led-uid",
+ /* 8 */ "", "", "", "", "", "", "", "";
+};
+
+&gpio4 {
+ gpio-line-names =
+ /* 0 */ "", "", "", "", "", "", "", "",
+ /* 8 */ "", "", "", "", "", "", "", "power-chassis-good";
+};
+
&pinctrl {
key_pins: mux-keys {
groups = "gspi", "sspi";
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: nuvoton,wpcm450-supermicro-x9sci-ln4f: Add GPIO line names
2022-11-01 10:29 [PATCH] ARM: dts: nuvoton,wpcm450-supermicro-x9sci-ln4f: Add GPIO line names Jonathan Neuschäfer
@ 2022-11-02 22:52 ` Joel Stanley
0 siblings, 0 replies; 2+ messages in thread
From: Joel Stanley @ 2022-11-02 22:52 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: openbmc, linux-gpio, devicetree, Rob Herring, Krzysztof Kozlowski,
linux-kernel
On Tue, 1 Nov 2022 at 10:29, Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
>
> To make gpioinfo output more useful and enable gpiofind usage, add line
> names for GPIOs where the function is known.
>
> This patch follows the naming convention defined for OpenBMC, as much as
> possible:
>
> https://github.com/openbmc/docs/blob/master/designs/device-tree-gpio-naming.md
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> .../nuvoton-wpcm450-supermicro-x9sci-ln4f.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> index 26fed97f8ff4a..d4472ffdac928 100644
> --- a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> +++ b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> @@ -58,6 +58,24 @@ heartbeat {
> };
> };
>
> +&gpio0 {
> + gpio-line-names =
> + /* 0 */ "", "host-reset-control-n", "", "", "", "", "", "",
> + /* 8 */ "", "", "", "", "power-chassis-control-n", "", "uid-button", "";
> +};
> +
> +&gpio1 {
> + gpio-line-names =
> + /* 0 */ "", "", "", "", "led-heartbeat", "", "", "led-uid",
> + /* 8 */ "", "", "", "", "", "", "", "";
> +};
> +
> +&gpio4 {
> + gpio-line-names =
> + /* 0 */ "", "", "", "", "", "", "", "",
> + /* 8 */ "", "", "", "", "", "", "", "power-chassis-good";
> +};
> +
> &pinctrl {
> key_pins: mux-keys {
> groups = "gspi", "sspi";
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-02 22:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-01 10:29 [PATCH] ARM: dts: nuvoton,wpcm450-supermicro-x9sci-ln4f: Add GPIO line names Jonathan Neuschäfer
2022-11-02 22:52 ` Joel Stanley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).