From: Joel Stanley <joel@jms.id.au>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed@lists.ozlabs.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option
Date: Tue, 11 Dec 2018 10:46:26 +1030 [thread overview]
Message-ID: <CACPK8XfxQxMqLo10FSRPHdUVt4vr5K32xB2C_SXLAPEza--v0w@mail.gmail.com> (raw)
In-Reply-To: <1544487006.3301683.1605247720.567E9685@webmail.messagingengine.com>
On Tue, 11 Dec 2018 at 10:40, Andrew Jeffery <andrew@aj.id.au> wrote:
>
>
>
> On Tue, 11 Dec 2018, at 10:35, Nathan Chancellor wrote:
> > Clang does not support this option:
> >
> > warning: unknown warning option '-Woverride-init'; did you mean
> > '-Woverride-module'? [-Wunknown-warning-option]
> > 1 warning generated.
> >
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>
> Acked-by: Andrew Jeffery <andrew@aj.id.au>
Thanks Nathan.
Andrew explained to me that this warning helps find bugs when
developing the complicated (some would say crazy) set of macros that
this pinctrl driver uses. It would be good to have this warning
available in clang. Do we have a clang issue opened for that?
Acked-by: Joel Stanley <joel@jms.id.au>
Cheers,
Joel
next prev parent reply other threads:[~2018-12-11 0:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 0:05 [PATCH] pinctrl: aspeed: Wrap -Woverride-init with cc-option Nathan Chancellor
2018-12-11 0:10 ` Andrew Jeffery
2018-12-11 0:16 ` Joel Stanley [this message]
2018-12-11 0:25 ` Nathan Chancellor
2018-12-16 0:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8XfxQxMqLo10FSRPHdUVt4vr5K32xB2C_SXLAPEza--v0w@mail.gmail.com \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).