linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	linux-gpio@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v2 1/2] gpiolib: Return label, if set, for IRQ only line
Date: Mon, 17 Jun 2024 09:32:02 +0200	[thread overview]
Message-ID: <CACRpkdY2fxg6uUkbezaR8wAFEUnyOrOW7WqbTEjEF9SzAoQR3Q@mail.gmail.com> (raw)
In-Reply-To: <20240530191418.1138003-2-andriy.shevchenko@linux.intel.com>

On Thu, May 30, 2024 at 9:14 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> If line has been locked as IRQ without requesting,
> still check its label and return it, if not NULL.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

I'm OK with it personally, the perfect solution would be to catenate
"interrupt" to the line name so we don't miss the information that the
line is used for interrupts in case of proper labels, but it's not a big
problem.

Yours,
Linus Walleij

  reply	other threads:[~2024-06-17  7:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30 19:12 [PATCH v2 0/2] gpiolib: Show IRQ line in debugfs Andy Shevchenko
2024-05-30 19:12 ` [PATCH v2 1/2] gpiolib: Return label, if set, for IRQ only line Andy Shevchenko
2024-06-17  7:32   ` Linus Walleij [this message]
2024-05-30 19:12 ` [PATCH v2 2/2] gpiolib: Show more info for interrupt only lines in debugfs Andy Shevchenko
2024-05-31 11:19   ` Alexander Stein
2024-05-31 13:30     ` Andy Shevchenko
2024-06-03  9:06       ` Alexander Stein
2024-05-31 14:09     ` Andy Shevchenko
2024-06-04  8:17 ` [PATCH v2 0/2] gpiolib: Show IRQ line " Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdY2fxg6uUkbezaR8wAFEUnyOrOW7WqbTEjEF9SzAoQR3Q@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brgl@bgdev.pl \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).