From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22D10165F1E for ; Mon, 2 Sep 2024 09:08:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725268125; cv=none; b=YLd/vTw02iBgnX5G2vVVVzMe3dJY1NyDtuMfv/WK/qczqa2K8Ptz8OqgAYJXT0QoNDI89soYnvdPdeN8arD9YnK6JJgldjz9iDVo//lA/0ZMN8pvaBmlJSqCJ7mwJTkMIBi42934Q85VsDXEcnuCYUwT/xD4TOoMFoLL1L6FKig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725268125; c=relaxed/simple; bh=ItlPypp6WrCWIb6a+iZ6UnRF5dm/ZOiMxnKIf5htWU8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=lTI/StfqeTJXJ0LhEkNM/kVebjCe5AR6NwgQBFtVhHsfHvFPVYLwKrD2gpi0oXHLEa3eerOJxln5ZgUHWzWmbExPSn0LL58ooUaz5WySfNP/edizBVJGGqHXelue6HIPVtN90ZCJ4Lg0ShyEn9mSWF+eU3CDaxyP+w3VTpkPsJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=uuD8bzvM; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uuD8bzvM" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-533488ffaebso4750298e87.0 for ; Mon, 02 Sep 2024 02:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725268121; x=1725872921; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ItlPypp6WrCWIb6a+iZ6UnRF5dm/ZOiMxnKIf5htWU8=; b=uuD8bzvM5C/y53wR6FUbASg+81EL8koD7lGuCaa/PrYnbVC4tphzuiUMNWzrPBrvkn QmrRjFFLVscLw54V0oWPo058hxyxoe619I0jMbd26JFST4M/LG/XA/pNL+Eg7EIgj1yI 3CfAkGCJKLMxY1F2Uhhzbfv5eoI+EtVzU5uZlScYbhjkdBlZB+/DyNjChHXI+DIkO+4O QHXHZGzPT1a/4dQkldFj+dc/B4YhywFYcOwi8t+pONPkbLX9TGTGIPA8wWkVgTFCYKTm zCoYqIjA1eLMg+jP+u7ycYXFzBGK/9PCtOeubwSE/axuDrrFy41t4mmDvbOT0HTPNiG+ hbuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725268121; x=1725872921; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ItlPypp6WrCWIb6a+iZ6UnRF5dm/ZOiMxnKIf5htWU8=; b=l93XA3YCIEvgxF9Zxi5jeWXMoe1mv2NTzEQfyiTHalCUdYRfvHiWI7e6zSbuG81gWp Jx63cGOYoRlvZdwEPAdrgQB+H9p2NlAVA1db45r6zFu0RfeDQNvdjpEnO4s3eHIeGSYV GJNlKrwZlKboOHKQA765OQKrWf8dtKTH1xHr35js64Djvb761v7XbQ0FG7YnB83NfbpE JJiTQQ975IKrteTkXXKhyA9moi/cplpJt8bISNSQYGDIoP8SMcbf1ltHIZmbX1VVUjMs h11DHA8ZHwIWmSeYksbykYL1plHLvaNrsErMo2yWY2uNXavK5SmMGvFQmx/soHTtKV41 276g== X-Forwarded-Encrypted: i=1; AJvYcCV/sBlLx/4TsTG9HZf7ctlzhLfR6I8JjEhZ6f5+dQPM8eXTatsymDjb7WhFICemQrMPozFdg25L3H08@vger.kernel.org X-Gm-Message-State: AOJu0Yy/GwIIi/B1O91LKF6L3BhvGXeJVctEazUJkuN4weWuPIoWQmG1 zvhaXB3XJBJpUXYIgbrsz59ahq4pZZAZeH9giY2kqE1eYCaYeUYZiS7cYdGLNkv5Mek8KvWF9yQ fkCjPV5u+fexFFDb2nEBhCZsa3hQ2D9WmpCHPmg== X-Google-Smtp-Source: AGHT+IE7Gmr8DRXU57qN/PlvHfcPdekTg2Ympj1QWPZ+v6eYceQhpU7ghw98R1G+yXBVxygGtcP2A1ooOEzFQ96QHpg= X-Received: by 2002:a05:6512:3d24:b0:52e:a68a:6076 with SMTP id 2adb3069b0e04-53546bb4d0fmr7358027e87.49.1725268120534; Mon, 02 Sep 2024 02:08:40 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240830-x1e80100-bypass-pdc-v1-1-d4c00be0c3e3@linaro.org> In-Reply-To: <20240830-x1e80100-bypass-pdc-v1-1-d4c00be0c3e3@linaro.org> From: Linus Walleij Date: Mon, 2 Sep 2024 11:08:29 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: qcom: x1e80100: Bypass PDC wakeup parent for now To: Stephan Gerhold Cc: Bjorn Andersson , Konrad Dybcio , Rajendra Nayak , Maulik Shah , Sibi Sankar , Abel Vesa , Johan Hovold , Srinivas Kandagatla , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 30, 2024 at 11:09=E2=80=AFAM Stephan Gerhold wrote: > On X1E80100, GPIO interrupts for wakeup-capable pins have been broken sin= ce > the introduction of the pinctrl driver. This prevents keyboard and touchp= ad > from working on most of the X1E laptops. So far we have worked around thi= s > by manually building a kernel with the "wakeup-parent" removed from the > pinctrl node in the device tree, but we cannot expect all users to do tha= t. > > Implement a similar workaround in the driver by clearing the wakeirq_map > for X1E80100. This avoids using the PDC wakeup parent for all GPIOs > and handles the interrupts directly in the pinctrl driver instead. > > The PDC driver needs additional changes to support X1E80100 properly. > Adding a workaround separately first allows to land the necessary PDC > changes through the normal release cycle, while still solving the more > critical problem with keyboard and touchpad on the current stable kernel > versions. Bypassing the PDC is enough for now, because we have not yet > enabled the deep idle states where using the PDC becomes necessary. > > Cc: stable@vger.kernel.org > Fixes: 05e4941d97ef ("pinctrl: qcom: Add X1E80100 pinctrl driver") > Signed-off-by: Stephan Gerhold Patch applied for fixes, excellent work as always. Thanks! Yours, Linus Walleij