From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC5916FF27 for ; Tue, 28 May 2024 13:54:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716904458; cv=none; b=UZJYq2O8iwxgLuwZFX06AQBqB3dtJha5PcKD2ioBNocfqs/sdUkXyUyuiMRRTW+QXMRhIblWq75xLmEisxYFoNjq0+564H6mdkTfh40Hg9SjStyxM2eTy1NPtGb/yuw4fbJK0AKQQZJZR+E1FqIVfZfoEm5xpG/ZASeetf3b36o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716904458; c=relaxed/simple; bh=7FRvHhRIIGYDk4+qwxfvO9/uo5NTHqwlQyzNXACIsqE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=l7L+HVLJiNjhbwy79F3GgOrK+gKSoWp3gvmhjJv7To/RK1kXIF2mxHsWBIbnW+WYTQijYfgtrIWLe3dvnoJ+8wnUWjqSEfu2QxaTNgfqsAnkdAwhXWpVCrWdxmdLQbhw49JWy4mYDufngPaFakMEQdhnqq6rCBZ6DsGGI56k0x0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tSQ0mrHG; arc=none smtp.client-ip=209.85.219.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tSQ0mrHG" Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-df4e6ece05aso873726276.0 for ; Tue, 28 May 2024 06:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716904456; x=1717509256; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7FRvHhRIIGYDk4+qwxfvO9/uo5NTHqwlQyzNXACIsqE=; b=tSQ0mrHG3+n3PGa7X9pcZE1Chu/Ou4kJD5PRZeuVs6X0UgWzGhjAKz12y4MXw9+B08 QpdwOLF04csZe9v+E/6RDvFZ3pFEHnNLPHykMSobr+H4Jc8N0qZuVuNMqA7cemTP7E/P Br7A5Q3p7PFXO+QdwqJs3tnZm8XLaFvdTuGZCpqwrfLfYuqi+ZlQxtMsb873oasKObTE Um9H50l7SA449CHzSMzd1Bm8MA6HBYGxHXLL6SYocnxsHjW/yjCkx1XQOQO2wiELJnMf /F+Js73JovAr7xSKVQ+N1cf1wa7OoZ7ij2x61L4Ty6hgGo7c6YGFH+Wp1QI5BM2Mm+z5 7JRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716904456; x=1717509256; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7FRvHhRIIGYDk4+qwxfvO9/uo5NTHqwlQyzNXACIsqE=; b=u6dmf0XDmOb9kJGIeoginf6kRBzjYb+DwMA5Cp5guwB17uTOPkSJkOPxEjQWNQ3FeM PJqDFt8yHm4qdFEXiu3+Gqu2sKMv4FsAtluzY5Ku5eV2RMQQb5l6SPHnHBgUpFxLHe9f Xo3OIujJI8i/GERcx7333I5Glzdf3Ut0IzkCuAWm2NgjvI6mW7Y+OOgJ64eEjxYnUq+T qf58oXNJm3umwA3A3HeOIwwvekpdQ3wD6ikM/b2jZLopROQJY7B2sjAXt2nyh94bu/OU Vr+FFpaVtohPQo5y7Q3PCMDs7EsyQANPdrH6t093oEPtp768EjwtwxdYvOuoFSha0XQy My+Q== X-Forwarded-Encrypted: i=1; AJvYcCUBV4HiVrLFTM5dhzf3Xef+ZjufzqYtNDsHsTokdGTraq94UDDA5cjRSIfJQ8mTfrnCVzUB3nBW7vUTRVmss5hGHt/PsZ8Qr8tJRA== X-Gm-Message-State: AOJu0YxSgZsEvDU4jo6V1HLMGpU46fB+5CF+Ion6WVtQyKH2BSNpvUTH M3eRFjh9GAaQN5lcjsvXAqddAEsLhFngcQR/g0uZZRa7eS1mO4/HshGpfjkkIYe6azFLJD5zlen SqEeQjrOaTuqg8tgIsLl1i9u74TwlldFxqqFBeQ== X-Google-Smtp-Source: AGHT+IGiPfPdnxrsrhzRu1zp22yduOAlK20srMU3ZfVqa4PYk+PdmHe6VAHg28ob32G6Sc5b0+jA9ivDKnJzxrYwPFU= X-Received: by 2002:a25:a545:0:b0:deb:42d2:c299 with SMTP id 3f1490d57ef6-df7721ff9dbmr11796718276.55.1716904456264; Tue, 28 May 2024 06:54:16 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240527022036.31985-1-user@blabla> In-Reply-To: <20240527022036.31985-1-user@blabla> From: Linus Walleij Date: Tue, 28 May 2024 15:54:04 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: ralink: mt76x8: fix pinmux function To: liweihao Cc: arinc.unal@arinc9.com, sergio.paracuellos@gmail.com, sean.wang@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, linux-mips@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, May 27, 2024 at 4:21=E2=80=AFAM liweihao wr= ote: > From: Weihao Li > > The current version of the pinctrl driver has some issues: > > 1. Duplicated "gpio" pmx function > > The common code will add a "gpio" pmx functon to every pin group, so > it's not necessary to define a separate "gpio" pmx function in pin > groups. > > 2. Duplicated pmx function name > > There are some same function name in different pin groups, which will > cause some problems. For example, when we want to use PAD_GPIO0 as > refclk output function, the common clk framework code will search the > entire pin function lists, then return the first one matched, in this > case the matched function list only include the PAD_CO_CLKO pin group > because there are three "refclk" pin function, which is added by > refclk_grp, spi_cs1_grp and gpio_grp. > > To solve this problem, a simple way is just add a pingrp refix to > function name like mt7620 pinctrl driver does. > > 3. Useless "-" or "rsvd" functon > > It's really unnecessary to add a reserved pin mux function to the > function lists, because we never use it. > > Signed-off-by: Weihao Li The patch looks good to me and Sergio: patch applied so it gets some testing in linux-next. If Arinc has issues with it or something else occurs I can always drop it again. Yours, Linus Walleij