From: Linus Walleij <linus.walleij@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 1/2] pinctrl: pinconf-generic: scan also referenced phandle node
Date: Fri, 27 Mar 2015 09:52:10 +0100 [thread overview]
Message-ID: <CACRpkdYFY6Lavx6hu9gUO0KHL6yQv_N6FpqpDRtuRznfqPmthQ@mail.gmail.com> (raw)
In-Reply-To: <a7b25eb6f4fd888e9ac600959cf4216ffa11921e.1426796262.git.baruch@tkos.co.il>
On Thu, Mar 19, 2015 at 9:17 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> Make pinconf_generic_dt_node_to_map() also scan the dt pin configuration node
> directly referenced by phandle, not only its child nodes.
>
> The "parent scan" feature needs a few other changes:
>
> * Move the pinconf_generic_dt_node_to_map() error handling code to a common
> place, under the 'exit' label.
>
> * Move the pins/groups strings count earlier in
> pinconf_generic_dt_subnode_to_map(), to allow us to bail out early when
> these properties are missing or wrong
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
phandle? Is's the parent node right?
Patch applied anyway, the code looks exactly like what I wanted.
Yours,
Linus Walleij
prev parent reply other threads:[~2015-03-27 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 20:17 [PATCH 1/2] pinctrl: pinconf-generic: scan also referenced phandle node Baruch Siach
2015-03-19 20:17 ` [PATCH 2/2] pinctrl: pinconf-generic: add dt node names to error messages Baruch Siach
2015-03-27 8:53 ` Linus Walleij
2015-03-27 8:52 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYFY6Lavx6hu9gUO0KHL6yQv_N6FpqpDRtuRznfqPmthQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=baruch@tkos.co.il \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).