From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 2/8] drivers/pinctrl: make mediatek/pinctrl-mt6397 driver explicitly non-modular Date: Wed, 9 Mar 2016 10:01:36 +0700 Message-ID: References: <1456778924-20730-1-git-send-email-paul.gortmaker@windriver.com> <1456778924-20730-3-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ob0-f175.google.com ([209.85.214.175]:34603 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbcCIDBg (ORCPT ); Tue, 8 Mar 2016 22:01:36 -0500 Received: by mail-ob0-f175.google.com with SMTP id ts10so34163867obc.1 for ; Tue, 08 Mar 2016 19:01:36 -0800 (PST) In-Reply-To: <1456778924-20730-3-git-send-email-paul.gortmaker@windriver.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Matthias Brugger , Hongzhou Yang , "linux-gpio@vger.kernel.org" , "moderated list:ARM/Mediatek SoC support" On Tue, Mar 1, 2016 at 3:48 AM, Paul Gortmaker wrote: > The Kconfig for this driver is currently: > > config PINCTRL_MT6397 > bool "Mediatek MT6397 pin control" if COMPILE_TEST && !MFD_MT6397 > > ...meaning that it is currently not being built as a module by anyone. > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > Cc: Linus Walleij > Cc: Matthias Brugger > Cc: Hongzhou Yang > Cc: linux-gpio@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Signed-off-by: Paul Gortmaker Patch applied with Honzhou's ACK. Yours, Linus Walleij