[PATCH] pinctrl/amd: Add device HID for new AMD GPIO controller

[PATCH] pinctrl/amd: Add device HID for new AMD GPIO controller

[Maximilian Luz]

Add device HID AMDI0031 to the AMD GPIO controller driver match table.
This controller can be found on Microsoft Surface Laptop 4 devices and
seems similar enough that we can just copy the existing AMDI0030 entry.

Cc: <stable@vger.kernel.org> # 5.10+
Tested-by: Sachi King <nakato@nakato.io>
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
---
 drivers/pinctrl/pinctrl-amd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c
index 2d4acf21117c..c5950a3b4e4c 100644
--- a/drivers/pinctrl/pinctrl-amd.c
+++ b/drivers/pinctrl/pinctrl-amd.c
@@ -991,6 +991,7 @@ static int amd_gpio_remove(struct platform_device *pdev)
 static const struct acpi_device_id amd_gpio_acpi_match[] = {
 	{ "AMD0030", 0 },
 	{ "AMDI0030", 0},
+	{ "AMDI0031", 0},
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, amd_gpio_acpi_match);
-- 
2.31.1

Re: [PATCH] pinctrl/amd: Add device HID for new AMD GPIO controller

[Linus Walleij]

On Wed, May 12, 2021 at 11:03 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:

> Add device HID AMDI0031 to the AMD GPIO controller driver match table.
> This controller can be found on Microsoft Surface Laptop 4 devices and
> seems similar enough that we can just copy the existing AMDI0030 entry.
>
> Cc: <stable@vger.kernel.org> # 5.10+

Why? It's hardly a regression?

> Tested-by: Sachi King <nakato@nakato.io>
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>

I've applied the patch for next without the stable tag for now.

Yours,
Linus Walleij

Re: [PATCH] pinctrl/amd: Add device HID for new AMD GPIO controller

[Maximilian Luz]

On 20/05/2021 01:50, Linus Walleij wrote:
> On Wed, May 12, 2021 at 11:03 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
> 
>> Add device HID AMDI0031 to the AMD GPIO controller driver match table.
>> This controller can be found on Microsoft Surface Laptop 4 devices and
>> seems similar enough that we can just copy the existing AMDI0030 entry.
>>
>> Cc: <stable@vger.kernel.org> # 5.10+
> 
> Why? It's hardly a regression?

Because that ID is already in use on the Surface Laptop 4 and
potentially other AMD-based laptops that are already available for
purchase. Not having it in stable means that people may have to deal
with some things not working (as this may prevent other drivers relying
on GPIOs from working) until 5.14 is available on their distribution of
choice.

Given the size of this change, I hardly think that's necessary. Which
is, I believe, also why the stable-kernel-rules doc points out that new
device IDs are (generally) allowed.

Regards,
Max

Re: [PATCH] pinctrl/amd: Add device HID for new AMD GPIO controller

[Andy Shevchenko]

On Thu, May 20, 2021 at 01:50:50AM +0200, Linus Walleij wrote:
> On Wed, May 12, 2021 at 11:03 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
> 
> > Add device HID AMDI0031 to the AMD GPIO controller driver match table.
> > This controller can be found on Microsoft Surface Laptop 4 devices and
> > seems similar enough that we can just copy the existing AMDI0030 entry.
> >
> > Cc: <stable@vger.kernel.org> # 5.10+
> 
> Why? It's hardly a regression?

IIRC the stable policy allows to backport new IDs.

> > Tested-by: Sachi King <nakato@nakato.io>
> > Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
> 
> I've applied the patch for next without the stable tag for now.

It can be pulled to stable afterwards anyway :-)

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] pinctrl/amd: Add device HID for new AMD GPIO controller

[Linus Walleij]

On Thu, May 20, 2021 at 11:09 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Thu, May 20, 2021 at 01:50:50AM +0200, Linus Walleij wrote:
> > On Wed, May 12, 2021 at 11:03 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
> >
> > > Add device HID AMDI0031 to the AMD GPIO controller driver match table.
> > > This controller can be found on Microsoft Surface Laptop 4 devices and
> > > seems similar enough that we can just copy the existing AMDI0030 entry.
> > >
> > > Cc: <stable@vger.kernel.org> # 5.10+
> >
> > Why? It's hardly a regression?
>
> IIRC the stable policy allows to backport new IDs.

You're right.

> > > Tested-by: Sachi King <nakato@nakato.io>
> > > Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
> >
> > I've applied the patch for next without the stable tag for now.
>
> It can be pulled to stable afterwards anyway :-)

Nah I'll tag it back on. But it goes upstream with the rest of
patches for v5.14 in the merge window because it is not
urgent.

Yours,
Linus Walleij