From: Linus Walleij <linus.walleij@linaro.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
Carlo Caione <carlo@caione.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] pinctrl: meson: fix pull bits
Date: Wed, 31 Oct 2018 15:05:16 +0100 [thread overview]
Message-ID: <CACRpkdYJW34oRmm0ZBivwsa7mMXhrj8hxz+ovXNwnOETs3xrog@mail.gmail.com> (raw)
In-Reply-To: <20181029151340.9087-1-jbrunet@baylibre.com>
On Mon, Oct 29, 2018 at 4:13 PM Jerome Brunet <jbrunet@baylibre.com> wrote:
> This patchset fixes the inversion between pull (up/down) and pull enable
> bits on the GPIO AO bank of all amlogic when have, except the axg family.
>
> The problem has been found while testing bias setting on the libretech
> aml-s905x-cc on GPIO_AO 5. Unfortunately the bias register of this bank is
> not described in the public datasheet of the s905x, but it is in the
> one of the A113D, which gave a clue.
>
> This was tested on gxl libretech aml-s905x-cc. Since all Amlogic we have
> got so far derive from each other, there is no reason for things to be
> any different on the meson8(b).
>
> I would have preferred to make a single patch to fix this but the commit
> introducing the mistake the is different for each SoC, so a single patch
> could be more difficult/annoying to backport.
All patches applied for fixes.
Thanks for drilling into this!
Yours,
Linus Walleij
prev parent reply other threads:[~2018-10-31 14:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 15:13 [PATCH 0/4] pinctrl: meson: fix pull bits Jerome Brunet
2018-10-29 15:13 ` [PATCH 1/4] pinctrl: meson: fix gxbb ao pull register bits Jerome Brunet
2018-10-29 15:13 ` [PATCH 2/4] pinctrl: meson: fix gxl " Jerome Brunet
2018-10-29 15:13 ` [PATCH 3/4] pinctrl: meson: fix meson8 " Jerome Brunet
2018-10-29 15:13 ` [PATCH 4/4] pinctrl: meson: fix meson8b " Jerome Brunet
2018-10-31 14:05 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYJW34oRmm0ZBivwsa7mMXhrj8hxz+ovXNwnOETs3xrog@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=carlo@caione.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).