From: Linus Walleij <linus.walleij@linaro.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: ralink: pinctrl-rt2880: avoid to error in calls is pin is already enabled
Date: Mon, 7 Jun 2021 09:08:37 +0200 [thread overview]
Message-ID: <CACRpkdYLwdgws+fDcb_hNz2=WD4+qkHiwWQgpgFNfWLU=PwSiw@mail.gmail.com> (raw)
In-Reply-To: <20210604055337.20407-1-sergio.paracuellos@gmail.com>
On Fri, Jun 4, 2021 at 7:53 AM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:
> In 'rt2880_pmx_group_enable' driver is printing an error and returning
> -EBUSY if a pin has been already enabled. This becomes in anoying messages
> in the caller when this happens like the following:
>
> rt2880-pinmux pinctrl: pcie is already enabled
> mt7621-pci 1e140000.pcie: Error applying setting, reverse things back
>
> To avoid this just print the already enabled message in the pinctrl
> driver and return 0 instead to don't confuse the user with a real
> bad problem.
>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Patch applied for fixes.
Yours,
Linus Walleij
prev parent reply other threads:[~2021-06-07 7:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 5:53 [PATCH] pinctrl: ralink: pinctrl-rt2880: avoid to error in calls is pin is already enabled Sergio Paracuellos
2021-06-07 7:08 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYLwdgws+fDcb_hNz2=WD4+qkHiwWQgpgFNfWLU=PwSiw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergio.paracuellos@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).