From: Linus Walleij <linus.walleij@linaro.org>
To: "Duje Mihanović" <duje.mihanovic@skole.hr>,
"Chris Packham" <chris.packham@alliedtelesis.co.nz>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andy Shevchenko <andy@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Lubomir Rintel <lkundrak@v3.sk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-hardening@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, afaerber@suse.de, balejk@matfyz.cz
Subject: Re: [PATCH RESEND v5 7/8] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte
Date: Sat, 30 Sep 2023 17:37:19 +0200 [thread overview]
Message-ID: <CACRpkdYOLjZ2thKdR7JoYxa2gr078AHO6JXu76fUU+dBzG7MPQ@mail.gmail.com> (raw)
In-Reply-To: <5715527.DvuYhMxLoT@radijator>
On Sat, Sep 30, 2023 at 10:25 AM Duje Mihanović <duje.mihanovic@skole.hr> wrote:
> On Saturday, September 30, 2023 12:05:41 AM CEST Linus Walleij wrote:
> > But it exists, so I can't say you can't use it. Not my choice.
> > I understand it is convenient.
> >
> > It is possible to switch later, but only if you have a unique
> > pin controller compatible so please add that.
>
> Maybe a dumb question. I might want to do this at some point to clean up the
> device tree a bit, are there any such pinctrl drivers I can use as a
> reference?
Since it's Marvell after all (albeit a descendant of the 20 yo
PXA platform!) I would expect new Marvell SoCs to be more alike
the AC5 bindings that Chris Packham merged only last year:
Documentation/devicetree/bindings/pinctrl/marvell,ac5-pinctrl.yaml
Driver:
drivers/pinctrl/mvebu/pinctrl-armada-xp.c
drivers/pinctrl/mvebu/pinctrl-mvebu.c
But if this pin controller is more related to PXA (Intel) hardware
than to either Kirkwood or Armada, you might want to do something
entirely different. It depends a bit on hardware.
Hardware such as pinctrl-single.c with one mux configuration
register per pin usually follow the Qualcomm way of doing
things, which is to simply have one group per pin, then that
can be associated with desired functions:
Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
this has the upside of using all the standard bindings for
bias etc. Driver:
drivers/pinctrl/qcom/pinctrl-msm.c
then qualcomm have subdrivers for each SoC calling into this
so you have to check "real" bindings and drivers such as:
Documentation/devicetree/bindings/pinctrl/qcom,sm8550-tlmm.yaml
drivers/pinctrl/qcom/pinctrl-sm8550.c
Yours,
Linus Walleij
next prev parent reply other threads:[~2023-09-30 15:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 15:41 [PATCH RESEND v5 0/8] Initial Marvell PXA1908 support Duje Mihanović
2023-09-29 15:41 ` [PATCH RESEND v5 1/8] gpio: pxa: disable pinctrl calls for MMP_GPIO Duje Mihanović
2023-10-02 7:19 ` Bartosz Golaszewski
2023-09-29 15:41 ` [PATCH RESEND v5 2/8] clk: mmp: Switch to use struct u32_fract instead of custom one Duje Mihanović
2023-09-29 21:50 ` Linus Walleij
2023-09-29 15:41 ` [PATCH RESEND v5 3/8] dt-bindings: clock: Add Marvell PXA1908 clock bindings Duje Mihanović
2023-09-30 9:30 ` Conor Dooley
2023-09-29 15:42 ` [PATCH RESEND v5 4/8] clk: mmp: Add Marvell PXA1908 clock driver Duje Mihanović
2023-09-29 15:42 ` [PATCH RESEND v5 5/8] dt-bindings: marvell: Document PXA1908 SoC Duje Mihanović
2023-09-29 15:42 ` [PATCH RESEND v5 6/8] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform Duje Mihanović
2023-09-29 15:42 ` [PATCH RESEND v5 7/8] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte Duje Mihanović
2023-09-29 22:05 ` Linus Walleij
2023-09-30 8:25 ` Duje Mihanović
2023-09-30 15:37 ` Linus Walleij [this message]
2023-09-29 15:42 ` [PATCH RESEND v5 8/8] MAINTAINERS: add myself as Marvell PXA1908 maintainer Duje Mihanović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYOLjZ2thKdR7JoYxa2gr078AHO6JXu76fUU+dBzG7MPQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=afaerber@suse.de \
--cc=andy@kernel.org \
--cc=balejk@matfyz.cz \
--cc=brgl@bgdev.pl \
--cc=catalin.marinas@arm.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=duje.mihanovic@skole.hr \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tony.luck@intel.com \
--cc=will@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).