From: Linus Walleij <linus.walleij@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Alexandru Stan <amstan@chromium.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: rockchip: Avoid losing interrupts when supporting both edges
Date: Thu, 8 Jan 2015 20:25:02 +0100 [thread overview]
Message-ID: <CACRpkdYOqbsTgNMx8n_NmAe2vtfx+mGRGpw3zUCqjsrFiH0ZVw@mail.gmail.com> (raw)
In-Reply-To: <1419274049-5069-1-git-send-email-dianders@chromium.org>
On Mon, Dec 22, 2014 at 7:47 PM, Doug Anderson <dianders@chromium.org> wrote:
> I was seeing cases where I was losing interrupts when inserting and
> removing SD cards. Sometimes the card would get "stuck" in the
> inserted state.
>
> I believe that the problem was related to the code to handle the case
> where we needed both rising and falling edges. This code would
> disable the interrupt as the polarity was switched. If an interrupt
> came at the wrong time it could be lost.
>
> We'll match what the gpio-dwapb.c driver does upstream and change the
> interrupt polarity without disabling things.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
Patch applied for fixes.
Yours,
Linus Walleij
prev parent reply other threads:[~2015-01-08 19:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 18:47 [PATCH] pinctrl: rockchip: Avoid losing interrupts when supporting both edges Doug Anderson
2014-12-27 18:29 ` Heiko Stübner
2015-01-08 19:25 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYOqbsTgNMx8n_NmAe2vtfx+mGRGpw3zUCqjsrFiH0ZVw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=amstan@chromium.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).