From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99A44C432C3 for ; Thu, 28 Nov 2019 08:43:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C6E12158A for ; Thu, 28 Nov 2019 08:43:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Cg3UGJZ/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727080AbfK1InH (ORCPT ); Thu, 28 Nov 2019 03:43:07 -0500 Received: from mail-lj1-f175.google.com ([209.85.208.175]:40830 "EHLO mail-lj1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726694AbfK1InG (ORCPT ); Thu, 28 Nov 2019 03:43:06 -0500 Received: by mail-lj1-f175.google.com with SMTP id s22so8537166ljs.7 for ; Thu, 28 Nov 2019 00:43:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0A7PAHErMXMiLWk/qlmZsqTmhq9IxC9JLoTdr7xyNiQ=; b=Cg3UGJZ/IHjtMYKApRdIpTGOjYJc7oZQQIUXDlVVuLP3ZdHHfbAyQAzgDnBxCPCKTa Ag94QWvb+bxutTkfIoKAxlGUwcodZW7arG8jINfdOpcytagMOOjdynJx+a4vOnjOlWcD O4kBCBV904z5Gx4HDBe4Kkivh1EMfeoY6sm3NkusDl+SLiwAZ/nKenGNR4LrwH/Clf0Z TWF72Yc8RJm2kXK/wnEkPZ9BD3wEKuwn7AQCsvIUB95fCmTVGdpGygpGZRicm/rXCni8 kzH76vSAgfF4z/qKxVwEBLcbx5O7xJM3gFq+5I0pbcK8BLpbIFk/7IHU0tDY0HlwOlZU ROaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0A7PAHErMXMiLWk/qlmZsqTmhq9IxC9JLoTdr7xyNiQ=; b=V+YUPqpki9au4dqNFl4fS8JJ4o/mqwNAnJMUwPGAzupzyH826R3u8flWj9wIO3Qkhm WJVeUpdieA2bjHtPVIufLYgXfu9QZQ+H0GY+NeAdd6qYRGlFCVqi6qh8mxxakqyN1m/d /80GMDpZW46hq80BP6NA7mXnrSIYNK1ZwAPoyGcgFMpl+pS6Fc214s8K+QFmMh40v4iq wmkyQzSEPqyt5Ecy682Cr1Jn0X3/Vm0IHFM7QVkxpijjMFkYewISzKUa2aQidwR8Xkgy YZd1Vtw8R9oM5P+QmWTLoa+IZqT553s/dttrcHHHgrK4PpET7uhyhqT0+ZYwRIsEEQcZ 9zKQ== X-Gm-Message-State: APjAAAUA8r/NjM5LKbU1kUMqlkDxhoD7N+OalVldqQaBqZ0y1thUgD8n LMpHExQB8pl6KgGOAQHyifTOBVpxFh0fMLWHzYrGRg== X-Google-Smtp-Source: APXvYqws92QE8ol5i46q8ypAJK4FbwtxVhvRJcANz8h3/vN7+CfayttMwqgCnT2dIJTYx8jp+gnG7guxcpOHvro8IG8= X-Received: by 2002:a2e:161b:: with SMTP id w27mr33863903ljd.183.1574930584775; Thu, 28 Nov 2019 00:43:04 -0800 (PST) MIME-Version: 1.0 References: <3c79a8b9-65e4-bfc9-d718-b8530fe1e672@c-s.fr> <582b5ccf-8993-6345-94d1-3c2fc94e4d4f@c-s.fr> <748eb503-b692-6d30-bc5e-94539a939b06@c-s.fr> <8b50ce56-0600-373d-178c-92aa780e5376@c-s.fr> <99f48a7e-e4f4-2a77-657c-452d7a656ec5@c-s.fr> In-Reply-To: From: Linus Walleij Date: Thu, 28 Nov 2019 09:42:53 +0100 Message-ID: Subject: Re: Boot failure with 5.4-rc5, bisected to 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO descriptors") To: Christophe Leroy Cc: linux-spi , Mark Brown , Fabio Estevam , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Nov 27, 2019 at 3:29 PM Christophe Leroy wrote: > Le 27/11/2019 =C3=A0 14:56, Linus Walleij a =C3=A9crit : > > I sent three patches, can you apply them on a clean tree > > and confirm it solves the problem (fingers crossed...) > > > > Thanks a lot for helping me fix this! > > The series is OK if using 'cs-gpios'. > > With 'gpios' in the DTS, I get: > > [ 3.154747] fsl_spi ff000a80.spi: cs1 >=3D max 1 > [ 3.159207] spi_master spi0: spi_device register error Ooops I looked over the gpiolib patch and found (I think) my mistake. I sent a v3 patch set that hopefully will make everything work as expected with just gpios =3D <...>; Yours, Linus Walleij