From: Linus Walleij <linus.walleij@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] gpiolib: shifters used as flags in gpio_ioctl()
Date: Tue, 23 Feb 2016 13:58:44 +0100 [thread overview]
Message-ID: <CACRpkdYTgvXDZjwi9TLkmwU+Afh1fBRFNNddrk_GRvZ3mQGcjg@mail.gmail.com> (raw)
In-Reply-To: <20160223094450.GB4030@mwanda>
On Tue, Feb 23, 2016 at 10:44 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> We weren't testing whether the bits were set correctly because we used
> shifters as flags. It means that we give the user incorrect line
> information in this new ioctl.
>
> Fixes: 521a2ad6f862 ('gpio: add userspace ABI for GPIO line information')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Already wrote and queued a similar patch yesterday, but thanks anyway Dan!
Yours,
Linus Walleij
prev parent reply other threads:[~2016-02-23 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 9:44 [patch] gpiolib: shifters used as flags in gpio_ioctl() Dan Carpenter
2016-02-23 12:58 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYTgvXDZjwi9TLkmwU+Afh1fBRFNNddrk_GRvZ3mQGcjg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=gnurou@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).