From: Linus Walleij <linus.walleij@linaro.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Keguang Zhang <keguang.zhang@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
Linux MIPS <linux-mips@linux-mips.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 6/8] gpio: loongson1: fix implicit assumption module.h is present
Date: Thu, 15 Sep 2016 14:03:02 +0200 [thread overview]
Message-ID: <CACRpkdYV_uKMaOX1ZLw_hq3BNGXbrtAerwhwnJQixdbLwAP2Uw@mail.gmail.com> (raw)
In-Reply-To: <20160912221631.15812-7-paul.gortmaker@windriver.com>
On Tue, Sep 13, 2016 at 12:16 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> The Kconfig for this file is:
>
> drivers/gpio/Kconfig:config GPIO_LOONGSON1
> drivers/gpio/Kconfig: tristate "Loongson1 GPIO support"
>
> ...but however it does not include module.h -- it in turn gets it from
> another header (gpio/driver.h) and we'd like to replace that with a
> forward delcaration of "struct module;" but if we do, this file will
> fail to compile.
>
> So we fix this first to avoid putting build failures into the bisect
> commit history.
>
> Cc: Keguang Zhang <keguang.zhang@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Cc: linux-mips@linux-mips.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Patch applied.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-09-15 12:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 22:16 [PATCH 0/8] gpio: wean gpio/driver.h off of module.h Paul Gortmaker
2016-09-12 22:16 ` [PATCH 1/8] gpio: palmas: fix implicit assumption module.h is present Paul Gortmaker
2016-09-15 11:58 ` Linus Walleij
2016-09-12 22:16 ` [PATCH 2/8] gpio: sx150x: " Paul Gortmaker
2016-09-15 11:59 ` Linus Walleij
2016-09-12 22:16 ` [PATCH 3/8] gpio: ts4800: " Paul Gortmaker
2016-09-15 12:00 ` Linus Walleij
2016-09-12 22:16 ` [PATCH 4/8] gpio: altera: " Paul Gortmaker
2016-09-15 12:01 ` Linus Walleij
2016-09-12 22:16 ` [PATCH 5/8] gpio: ath79: " Paul Gortmaker
2016-09-15 12:02 ` Linus Walleij
2016-09-12 22:16 ` [PATCH 6/8] gpio: loongson1: " Paul Gortmaker
2016-09-15 12:03 ` Linus Walleij [this message]
2016-09-12 22:16 ` [PATCH 7/8] gpio: wcove: " Paul Gortmaker
2016-09-15 12:04 ` Linus Walleij
2016-09-12 22:16 ` [PATCH 8/8] gpio: don't include module.h in shared driver header Paul Gortmaker
2016-09-15 12:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYV_uKMaOX1ZLw_hq3BNGXbrtAerwhwnJQixdbLwAP2Uw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=gnurou@gmail.com \
--cc=keguang.zhang@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).