From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 6/8] gpio: loongson1: fix implicit assumption module.h is present Date: Thu, 15 Sep 2016 14:03:02 +0200 Message-ID: References: <20160912221631.15812-1-paul.gortmaker@windriver.com> <20160912221631.15812-7-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-oi0-f54.google.com ([209.85.218.54]:33328 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934380AbcIOMDE (ORCPT ); Thu, 15 Sep 2016 08:03:04 -0400 Received: by mail-oi0-f54.google.com with SMTP id r126so65511355oib.0 for ; Thu, 15 Sep 2016 05:03:03 -0700 (PDT) In-Reply-To: <20160912221631.15812-7-paul.gortmaker@windriver.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Keguang Zhang , Alexandre Courbot , Linux MIPS , "linux-gpio@vger.kernel.org" On Tue, Sep 13, 2016 at 12:16 AM, Paul Gortmaker wrote: > The Kconfig for this file is: > > drivers/gpio/Kconfig:config GPIO_LOONGSON1 > drivers/gpio/Kconfig: tristate "Loongson1 GPIO support" > > ...but however it does not include module.h -- it in turn gets it from > another header (gpio/driver.h) and we'd like to replace that with a > forward delcaration of "struct module;" but if we do, this file will > fail to compile. > > So we fix this first to avoid putting build failures into the bisect > commit history. > > Cc: Keguang Zhang > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: linux-mips@linux-mips.org > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker Patch applied. Yours, Linus Walleij