From: Linus Walleij <linus.walleij@linaro.org>
To: fenglinw@codeaurora.org
Cc: "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
David Collins <collinsd@codeaurora.org>,
aghayal@codeaurora.org, wruan@codeaurora.org,
subbaram@codeaurora.org, kgunda@codeaurora.org
Subject: Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config
Date: Wed, 11 Oct 2017 10:24:50 +0200 [thread overview]
Message-ID: <CACRpkdYXAYPhGQ89rMg0zNmMFxApdmXPca9wkMnqsp17ik188w@mail.gmail.com> (raw)
In-Reply-To: <20170912003331.3092-1-fenglinw@codeaurora.org>
On Tue, Sep 12, 2017 at 2:32 AM, <fenglinw@codeaurora.org> wrote:
> From: Fenglin Wu <fenglinw@codeaurora.org>
>
> GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is
> configured. Update is_enabled flag in config_set() so that it can
> reflect GPIO status correctly. Also modify EN_CTL register based on
> is_enabled flag in config_set() to configure the GPIO properly.
>
> Signed-off-by: Fenglin Wu <fenglinw@codeaurora.org>
Patch applied with Björn's ACK.
Expecting follow-up fixes as discussed in this thread.
Yours,
Linus Walleij
prev parent reply other threads:[~2017-10-11 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 0:32 [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config fenglinw
2017-09-19 8:20 ` Linus Walleij
2017-10-05 16:27 ` Bjorn Andersson
2017-10-09 5:34 ` Fenglin Wu
2017-10-09 5:56 ` Bjorn Andersson
2017-10-10 0:17 ` Fenglin Wu
2017-10-11 5:48 ` Bjorn Andersson
2017-10-11 8:24 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYXAYPhGQ89rMg0zNmMFxApdmXPca9wkMnqsp17ik188w@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=aghayal@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=fenglinw@codeaurora.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=subbaram@codeaurora.org \
--cc=wruan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).