From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config Date: Wed, 11 Oct 2017 10:24:50 +0200 Message-ID: References: <20170912003331.3092-1-fenglinw@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-it0-f44.google.com ([209.85.214.44]:52977 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756661AbdJKIYv (ORCPT ); Wed, 11 Oct 2017 04:24:51 -0400 Received: by mail-it0-f44.google.com with SMTP id j140so1890313itj.1 for ; Wed, 11 Oct 2017 01:24:51 -0700 (PDT) In-Reply-To: <20170912003331.3092-1-fenglinw@codeaurora.org> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: fenglinw@codeaurora.org Cc: "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Bjorn Andersson , "linux-gpio@vger.kernel.org" , David Collins , aghayal@codeaurora.org, wruan@codeaurora.org, subbaram@codeaurora.org, kgunda@codeaurora.org On Tue, Sep 12, 2017 at 2:32 AM, wrote: > From: Fenglin Wu > > GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is > configured. Update is_enabled flag in config_set() so that it can > reflect GPIO status correctly. Also modify EN_CTL register based on > is_enabled flag in config_set() to configure the GPIO properly. > > Signed-off-by: Fenglin Wu Patch applied with Bj=C3=B6rn's ACK. Expecting follow-up fixes as discussed in this thread. Yours, Linus Walleij