* [PATCH] pinctrl: aw9523: fix mutex unlock in error path
@ 2025-06-19 17:35 Bartosz Golaszewski
2025-06-24 19:11 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Golaszewski @ 2025-06-19 17:35 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-gpio, linux-kernel, Bartosz Golaszewski, kernel test robot,
Dan Carpenter
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
We must unlock the mutex *after* the `out` label or we'd trigger a
deadlock in error path.
Fixes: dffe286e2428 ("pinctrl: aw9523: use new GPIO line value setter callbacks")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202506191952.A03cvn22-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/pinctrl/pinctrl-aw9523.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-aw9523.c b/drivers/pinctrl/pinctrl-aw9523.c
index c84454038419..2935b2cceb03 100644
--- a/drivers/pinctrl/pinctrl-aw9523.c
+++ b/drivers/pinctrl/pinctrl-aw9523.c
@@ -652,9 +652,9 @@ static int aw9523_gpio_set_multiple(struct gpio_chip *chip,
if (ret)
goto out;
}
- mutex_unlock(&awi->i2c_lock);
out:
+ mutex_unlock(&awi->i2c_lock);
return ret;
}
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: aw9523: fix mutex unlock in error path
2025-06-19 17:35 [PATCH] pinctrl: aw9523: fix mutex unlock in error path Bartosz Golaszewski
@ 2025-06-24 19:11 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2025-06-24 19:11 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: linux-gpio, linux-kernel, Bartosz Golaszewski, kernel test robot,
Dan Carpenter
On Thu, Jun 19, 2025 at 7:35 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> We must unlock the mutex *after* the `out` label or we'd trigger a
> deadlock in error path.
>
> Fixes: dffe286e2428 ("pinctrl: aw9523: use new GPIO line value setter callbacks")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/r/202506191952.A03cvn22-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-24 19:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-19 17:35 [PATCH] pinctrl: aw9523: fix mutex unlock in error path Bartosz Golaszewski
2025-06-24 19:11 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).