From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 8/9] gpio: 104-idio-16: make use of raw_spinlock variants Date: Tue, 28 Mar 2017 11:13:29 +0200 Message-ID: References: <9b15e28c4aeeade4b44e9a2bb06c12ded5d0990b.1490135047.git.julia@ni.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-it0-f53.google.com ([209.85.214.53]:35196 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754988AbdC1JNl (ORCPT ); Tue, 28 Mar 2017 05:13:41 -0400 Received: by mail-it0-f53.google.com with SMTP id y18so104983722itc.0 for ; Tue, 28 Mar 2017 02:13:40 -0700 (PDT) In-Reply-To: <9b15e28c4aeeade4b44e9a2bb06c12ded5d0990b.1490135047.git.julia@ni.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Julia Cartwright Cc: William Breathitt Gray , Alexandre Courbot , "linux-kernel@vger.kernel.org" , linux-rt-users@vger.kernel.org, "linux-gpio@vger.kernel.org" On Tue, Mar 21, 2017 at 11:43 PM, Julia Cartwright wrote: > The 104-idio-16 gpio driver currently implements an irq_chip for handling > interrupts; due to how irq_chip handling is done, it's necessary for the > irq_chip methods to be invoked from hardirq context, even on a a > real-time kernel. Because the spinlock_t type becomes a "sleeping" > spinlock w/ RT kernels, it is not suitable to be used with irq_chips. > > A quick audit of the operations under the lock reveal that they do only > minimal, bounded work, and are therefore safe to do under a raw spinlock. > > Signed-off-by: Julia Cartwright > --- > New patch as of v2 of series. Patch applied to the GPIO tree with William's ACK. Yours, Linus Walleij