* [PATCH] gpio: raspberrypi-exp: decrease refcount on firmware dt node
@ 2018-12-10 16:50 Nicolas Saenz Julienne
2018-12-16 0:20 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Saenz Julienne @ 2018-12-10 16:50 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski
Cc: linux-rpi-kernel, dave.stevenson, Nicolas Saenz Julienne,
linux-gpio, linux-kernel
We're getting a reference RPi's firmware node in order to be able to
communicate with it's driver. We should decrease the reference count on
the dt node after being done with it.
Fixes: a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
drivers/gpio/gpio-raspberrypi-exp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-raspberrypi-exp.c b/drivers/gpio/gpio-raspberrypi-exp.c
index d6d36d537e37..b77ea16ffa03 100644
--- a/drivers/gpio/gpio-raspberrypi-exp.c
+++ b/drivers/gpio/gpio-raspberrypi-exp.c
@@ -206,6 +206,7 @@ static int rpi_exp_gpio_probe(struct platform_device *pdev)
}
fw = rpi_firmware_get(fw_node);
+ of_node_put(fw_node);
if (!fw)
return -EPROBE_DEFER;
--
2.19.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: raspberrypi-exp: decrease refcount on firmware dt node
2018-12-10 16:50 [PATCH] gpio: raspberrypi-exp: decrease refcount on firmware dt node Nicolas Saenz Julienne
@ 2018-12-16 0:20 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2018-12-16 0:20 UTC (permalink / raw)
To: Nicolas Saenz Julienne
Cc: Bartosz Golaszewski, linux-rpi-kernel, Dave Stevenson,
open list:GPIO SUBSYSTEM, linux-kernel@vger.kernel.org
On Mon, Dec 10, 2018 at 5:50 PM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
> We're getting a reference RPi's firmware node in order to be able to
> communicate with it's driver. We should decrease the reference count on
> the dt node after being done with it.
>
> Fixes: a98d90e7d588 ("gpio: raspberrypi-exp: Driver for RPi3 GPIO expander via mailbox service")
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-16 0:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-10 16:50 [PATCH] gpio: raspberrypi-exp: decrease refcount on firmware dt node Nicolas Saenz Julienne
2018-12-16 0:20 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).