From: Linus Walleij <linus.walleij@linaro.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Fabien Parent <fparent@baylibre.com>,
Sean Wang <sean.wang@kernel.org>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] pinctrl: mediatek: move bit assignment
Date: Mon, 7 Jun 2021 00:49:01 +0200 [thread overview]
Message-ID: <CACRpkdY_jfYe1PNLrbrFMQBbcL+oucxOMxbREb8-LTCdANRv1g@mail.gmail.com> (raw)
In-Reply-To: <b3d9f92d-a311-0093-4243-b21f2646997f@gmail.com>
On Wed, Jun 2, 2021 at 2:34 PM Matthias Brugger <matthias.bgg@gmail.com> wrote:
> > -
> > + bit = BIT(pin & 0xf);
>
> I see this is already applied to linux-next, but I think the correct fix is to move
> bit = BIT(offset & pctl->devdata->mode_mask);
> just before calling regmap_write(...)
>
> I can provide a patch for that, if you want. Just let me know if I should base
> it against linux-next or if you will drop the fix proposed by you?
Just patch it in my tree, I merged more stuff on top and this
was just my quickfix to get next working.
Yours,
Linus Walleij
prev parent reply other threads:[~2021-06-06 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 9:19 [PATCH] pinctrl: mediatek: move bit assignment Linus Walleij
2021-06-02 12:34 ` Matthias Brugger
2021-06-06 22:49 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdY_jfYe1PNLrbrFMQBbcL+oucxOMxbREb8-LTCdANRv1g@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=fparent@baylibre.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lkp@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mkorpershoek@baylibre.com \
--cc=sean.wang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).