From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-gpio-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8647EC433F5
	for <linux-gpio@archiver.kernel.org>; Tue, 15 Mar 2022 01:19:42 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S242283AbiCOBUv (ORCPT <rfc822;linux-gpio@archiver.kernel.org>);
        Mon, 14 Mar 2022 21:20:51 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50376 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230185AbiCOBUv (ORCPT
        <rfc822;linux-gpio@vger.kernel.org>); Mon, 14 Mar 2022 21:20:51 -0400
Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BF35473A2
        for <linux-gpio@vger.kernel.org>; Mon, 14 Mar 2022 18:19:40 -0700 (PDT)
Received: by mail-yb1-xb32.google.com with SMTP id m67so980068ybm.4
        for <linux-gpio@vger.kernel.org>; Mon, 14 Mar 2022 18:19:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=CAQV7OW5DIVoy49mXItJtHDnpMN5TYYxiJrbhxC4jyk=;
        b=jDH/0OzYmEqK2xNtLP4C5LVw0ybx+9cFmcuBzO8v8nvbMZVcfdWLyuQ5azyCWwpKYX
         y6pyeV2rZU2akXuq+5RZ15ARo9wjY0ros0PMYNUCwaqfqw9zKW98Pan/9ENpwzGTi5nM
         GZgxWPDl3zEJPoqaweUa23Wn7sGRAhqfPJ/D7uowDIpC666MmZig5BOKGgnTMiKMQfWP
         rf0EgURF93cr4+pNa59EWV2ahfcUG1MIm/hRLJiny0vi5ygLsY9t12R1Vs/r1I0H00dk
         sJx+zX3m2ROXSyHcW1ViasJbMWkh9WSh8Y9HpED/hV3tV02CyHUyoY6PxeVUQg9kSCBk
         lIwA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=CAQV7OW5DIVoy49mXItJtHDnpMN5TYYxiJrbhxC4jyk=;
        b=5MdhR6VhpFoBrWnTNVkVRzNq2nYfG6ba7YI56IQqm0uRKJ1ukh+xeUWGHZyf/7X7TI
         gmAoKuGSB+9VwPIcQ0mx3tfLwI9gPJ/zWbDowaYSjyeGRdg3ohFIMv5/rNTBdYQUJf4L
         asdjbcB28mUF234uc1fr+Qh4S7qC5A8xmryqJBdxy2r2UREjUbhefYAfpZgYUN9kJMCS
         tHg/khQIziApc1a7CmFO3Ni+/BDoRzawEeYFDvagOmi9F/Mzy7g+J9FSf4zqf8z2a4eL
         0Z6KODavN5agLi3k4QWXzrGe1Ap2aUFMI55USTiMv4TRDZD66bRoh7+z7l/bw29EaipK
         qBFg==
X-Gm-Message-State: AOAM533r8/xMtWlAKVja55zTgDiTyALm4qWyNklS16pud30Ce+hIXSa+
        1sHcL8Y9Dhw8EuRd4PL5S7kGeQYhFWJEtdOyGD9Fig==
X-Google-Smtp-Source: ABdhPJwkeenfT24JdlbNiz6up7mPHv+kyB95NY4vskHaB3Ozp8o/ij49btgsTtJwb2QNcIsiElAwbcY8SDY22QhewC8=
X-Received: by 2002:a25:ab64:0:b0:633:6d02:ebc8 with SMTP id
 u91-20020a25ab64000000b006336d02ebc8mr2610032ybi.492.1647307179860; Mon, 14
 Mar 2022 18:19:39 -0700 (PDT)
MIME-Version: 1.0
References: <20220303080206.16463-1-tangmeng@uniontech.com>
In-Reply-To: <20220303080206.16463-1-tangmeng@uniontech.com>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Tue, 15 Mar 2022 02:19:28 +0100
Message-ID: <CACRpkdYaWFuuE2_p5My_PSLAPw3tumGaxJqMCiCvGFAPWrk2KA@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: berlin: fix error return code of berlin_pinctrl_build_state()
To:     Meng Tang <tangmeng@uniontech.com>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-gpio.vger.kernel.org>
X-Mailing-List: linux-gpio@vger.kernel.org

On Thu, Mar 3, 2022 at 9:02 AM Meng Tang <tangmeng@uniontech.com> wrote:

> When krealloc() fails and pctrl->functions is NULL, no error
> return code of berlin_pinctrl_build_state() is assigned.
> To fix this bug, ret is assigned with -ENOMEM when pctrl->functions
> is NULL.
>
> Signed-off-by: Meng Tang <tangmeng@uniontech.com>

Patch applied!

Yours,
Linus Walleij