From: Linus Walleij <linus.walleij@linaro.org>
To: bchihi@baylibre.com
Cc: sean.wang@kernel.org, matthias.bgg@gmail.com,
linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [v2, 0/2] Fix broken SET/CLR mode of a certain number of pins for MediaTek MT8385 SoC
Date: Mon, 7 Nov 2022 15:44:05 +0100 [thread overview]
Message-ID: <CACRpkdYdmG5cFenESg36BwVpJ7FDJunPH1Z8dJjHwmu+NW-etA@mail.gmail.com> (raw)
In-Reply-To: <20221021084708.1109986-1-bchihi@baylibre.com>
On Fri, Oct 21, 2022 at 10:47 AM <bchihi@baylibre.com> wrote:
> From: Balsam CHIHI <bchihi@baylibre.com>
>
> On MT8365, the SET/CLR of the mode is broken and some pins won't set or clear the modes correctly.
> To fix this issue, we add a specific callback mt8365_set_clr_mode() for this specific SoC.
> This callback uses the main R/W register to read/update/write the modes instead of using the SET/CLR register.
>
> This is the original patch series proposed by Fabien Parent <fparent@baylibre.com>.
> "https://lore.kernel.org/linux-arm-kernel/20220530123425.689459-1-fparent@baylibre.com/"
>
> Changelog:
> Changes in v2 :
> - Rebase on top of 6.1.0-rc1-next-20221020
> - Delete MTK_PINCTRL_MODE_SET_CLR_BROKEN quirk
> - Add mt8365_set_clr_mode() callback
Patches applied, no need to resend for small issues.
Sorry for taking so long, I wanted some feedback from the Mediatek
maintainers but haven't heard anything, so I just applied them.
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-11-07 14:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 8:47 [v2, 0/2] Fix broken SET/CLR mode of a certain number of pins for MediaTek MT8385 SoC bchihi
2022-10-21 8:47 ` [v2, 1/2] pinctrl: mediatek: common: add mt8365_set_clr_mode() callback for broken SET/CLR modes bchihi
2022-10-21 8:47 ` [v2, 2/2] pinctrl: mediatek: mt8365: use mt8365_set_clr_mode() callback bchihi
2022-10-31 16:40 ` [v2, 0/2] Fix broken SET/CLR mode of a certain number of pins for MediaTek MT8385 SoC Kevin Hilman
2022-11-02 9:22 ` Balsam CHIHI
2022-11-07 14:44 ` Linus Walleij [this message]
2022-11-16 10:51 ` Balsam CHIHI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYdmG5cFenESg36BwVpJ7FDJunPH1Z8dJjHwmu+NW-etA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bchihi@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).