From: Linus Walleij <linus.walleij@linaro.org>
To: Helmut Grohne <h.grohne@intenta.de>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Helmut Buchsbaum" <helmut.buchsbaum@gmail.com>
Subject: Re: [PATCH v2] gpio: zynq: initialize clock even without CONFIG_PM
Date: Wed, 8 Jun 2016 10:37:12 +0200 [thread overview]
Message-ID: <CACRpkdYo6wQapLO8_OD0VZR+PaJJmXAzA6VLimU+NPfJLb4DRg@mail.gmail.com> (raw)
In-Reply-To: <20160603121526.GA23642@laureti-dev>
On Fri, Jun 3, 2016 at 2:15 PM, Helmut Grohne <h.grohne@intenta.de> wrote:
> When the PM initialization was moved in the commit referenced below, the
> code enabling the clock was removed from the probe function. On
> CONFIG_PM=y kernels, this is not a problem as the pm resume hook enables
> the clock, but when power management is disabled, all those pm_*
> functions are noops and the clock is never enabled resulting in a
> dysfunctional gpio controller.
>
> Put the clock initialization back to support CONFIG_PM=n.
>
> Signed-off-by: Helmut Grohne <h.grohne@intenta.de>
> Fixes: 3773c195d387 ("gpio: zynq: Do PM initialization earlier to support gpio hogs")
This v2 patch applied for fixes and tagged for stable.
Yours,
Linus Walleij
prev parent reply other threads:[~2016-06-08 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 12:15 [PATCH v2] gpio: zynq: initialize clock even without CONFIG_PM Helmut Grohne
2016-06-03 13:01 ` Helmut Grohne
2016-06-08 8:37 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYo6wQapLO8_OD0VZR+PaJJmXAzA6VLimU+NPfJLb4DRg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=gnurou@gmail.com \
--cc=h.grohne@intenta.de \
--cc=helmut.buchsbaum@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).