* [PATCH] tools/gpio: Fix build error with musl libc
@ 2017-12-21 0:41 Joel Stanley
2017-12-21 12:51 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Joel Stanley @ 2017-12-21 0:41 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, linux-kernel, stable
The GPIO tools build fails when using a buildroot toolchain that uses musl
as it's C library:
arm-broomstick-linux-musleabi-gcc -Wp,-MD,./.gpio-event-mon.o.d \
-Wp,-MT,gpio-event-mon.o -O2 -Wall -g -D_GNU_SOURCE \
-Iinclude -D"BUILD_STR(s)=#s" -c -o gpio-event-mon.o gpio-event-mon.c
gpio-event-mon.c:30:6: error: unknown type name ‘u_int32_t’; did you mean ‘uint32_t’?
u_int32_t handleflags,
^~~~~~~~~
uint32_t
The glibc headers installed on my laptop include sys/types.h in
unistd.h, but it appears that musl does not.
Fixes: 97f69747d8b1 ("tools/gpio: add the gpio-event-mon tool")
Cc: stable@vger.kernel.org
Signed-off-by: Joel Stanley <joel@jms.id.au>
---
tools/gpio/gpio-event-mon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/gpio/gpio-event-mon.c b/tools/gpio/gpio-event-mon.c
index 1c14c2595158..4b36323ea64b 100644
--- a/tools/gpio/gpio-event-mon.c
+++ b/tools/gpio/gpio-event-mon.c
@@ -23,6 +23,7 @@
#include <getopt.h>
#include <inttypes.h>
#include <sys/ioctl.h>
+#include <sys/types.h>
#include <linux/gpio.h>
int monitor_device(const char *device_name,
--
2.15.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tools/gpio: Fix build error with musl libc
2017-12-21 0:41 [PATCH] tools/gpio: Fix build error with musl libc Joel Stanley
@ 2017-12-21 12:51 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2017-12-21 12:51 UTC (permalink / raw)
To: Joel Stanley; +Cc: linux-gpio, linux-kernel@vger.kernel.org, stable
On Thu, Dec 21, 2017 at 1:41 AM, Joel Stanley <joel@jms.id.au> wrote:
> The GPIO tools build fails when using a buildroot toolchain that uses musl
> as it's C library:
>
> arm-broomstick-linux-musleabi-gcc -Wp,-MD,./.gpio-event-mon.o.d \
> -Wp,-MT,gpio-event-mon.o -O2 -Wall -g -D_GNU_SOURCE \
> -Iinclude -D"BUILD_STR(s)=#s" -c -o gpio-event-mon.o gpio-event-mon.c
> gpio-event-mon.c:30:6: error: unknown type name ‘u_int32_t’; did you mean ‘uint32_t’?
> u_int32_t handleflags,
> ^~~~~~~~~
> uint32_t
>
> The glibc headers installed on my laptop include sys/types.h in
> unistd.h, but it appears that musl does not.
>
> Fixes: 97f69747d8b1 ("tools/gpio: add the gpio-event-mon tool")
> Cc: stable@vger.kernel.org
> Signed-off-by: Joel Stanley <joel@jms.id.au>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-21 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-21 0:41 [PATCH] tools/gpio: Fix build error with musl libc Joel Stanley
2017-12-21 12:51 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).