From: Linus Walleij <linus.walleij@linaro.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH 0/4] gpio: pxa: integrate with pincontrol
Date: Wed, 9 Dec 2015 23:58:22 +0100 [thread overview]
Message-ID: <CACRpkdZ0JZOsU7VuFyeM8akWTKHjksEC3-wB4zrx0NJBRD+agQ@mail.gmail.com> (raw)
In-Reply-To: <1448746665-13422-1-git-send-email-robert.jarzmik@free.fr>
On Sat, Nov 28, 2015 at 10:37 PM, Robert Jarzmik <robert.jarzmik@free.fr> wrote:
> Hi Linus, Alexandre and Haojian,
>
> This serie aims at several cleanups and improvements in the pxa gpio driver, to
I have concerns about this series.
I am worried that joining the banks into one gpio_chip makes it
impossible for you GPIOLIB_IRQCHIP. Usually that is possible and
preferrable when using a chained handler if e.g. one bank has
one IRQ line.
But overall that depends on how the IRQs map on this hardware.
Can you describe how the GPIO IRQs work on the PXA27x?
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-12-09 22:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 21:37 [PATCH 0/4] gpio: pxa: integrate with pincontrol Robert Jarzmik
2015-11-28 21:37 ` [PATCH 1/4] gpio: pxa: convert to one gpiochip Robert Jarzmik
2015-12-10 15:04 ` Linus Walleij
2015-12-10 17:28 ` Robert Jarzmik
2015-11-28 21:37 ` [PATCH 2/4] gpio: pxa: convert to devm_ioremap Robert Jarzmik
2015-12-10 15:05 ` Linus Walleij
2015-11-28 21:37 ` [PATCH 3/4] gpio: pxa: change the interrupt management Robert Jarzmik
2015-11-28 23:23 ` kbuild test robot
2015-11-29 10:03 ` Robert Jarzmik
2015-12-10 15:06 ` Linus Walleij
2015-11-28 21:37 ` [PATCH 4/4] gpio: pxa: add pin control gpio direction and request Robert Jarzmik
2015-12-10 17:33 ` Robert Jarzmik
2015-12-09 22:58 ` Linus Walleij [this message]
2015-12-10 7:28 ` [PATCH 0/4] gpio: pxa: integrate with pincontrol Robert Jarzmik
2015-12-10 15:02 ` Linus Walleij
2015-12-10 17:31 ` Robert Jarzmik
2015-12-14 13:42 ` Linus Walleij
2015-12-14 21:10 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZ0JZOsU7VuFyeM8akWTKHjksEC3-wB4zrx0NJBRD+agQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=gnurou@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).