From: Linus Walleij <linus.walleij@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Alexandre Courbot <gnurou@gmail.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
joeyli <jlee@suse.com>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v5] gpio: Add driver for ACPI INT0002 Virtual GPIO device
Date: Thu, 1 Jun 2017 17:29:30 +0200 [thread overview]
Message-ID: <CACRpkdZ2u8mxCCCNCPpL3d6LACSjjHTCOyok9NWM0WuW0XY3HA@mail.gmail.com> (raw)
In-Reply-To: <9fae1e2f-9d5b-2ba8-3bf5-4e1516e06332@redhat.com>
On Thu, Jun 1, 2017 at 5:20 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>> So again, the reason this - which is not a GPIO controller at all -
>> should anyways
>> be in drivers/gpio/ is that some firmware person think it's convenien >
>> Shouldn't this rather be in drivers/platform/x86?
>
>
> That is where it started, I'm fine with putting it back there.
>
>> You can still use the gpio driver abstraction.
>
> Ack, if you're ok with using the gpio driver abstraction while
> putting the driver in drivers/platform/x86 that might be the
> best way to deal with this.
OK let's proceed like that.
I guess I could be hopeless and require that it reimplement
the ACPI parser and whatnot just because it's not GPIO but
code duplication is a greater evil and thus modelling this as a
"GPIO" is the lesser evil, so I just have to accept it as such.
Yours,
Linus Walleij
next prev parent reply other threads:[~2017-06-01 15:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 10:42 [PATCH v5] gpio: Add driver for ACPI INT0002 Virtual GPIO device Hans de Goede
2017-05-24 11:23 ` Andy Shevchenko
2017-05-24 12:10 ` Hans de Goede
2017-05-24 23:12 ` Rafael J. Wysocki
2017-05-27 19:28 ` Rafael J. Wysocki
2017-06-01 15:11 ` Linus Walleij
2017-06-01 15:20 ` Hans de Goede
2017-06-01 15:29 ` Linus Walleij [this message]
2017-06-01 16:35 ` Rafael J. Wysocki
2017-06-01 15:23 ` Linus Walleij
2017-06-02 11:10 ` Andy Shevchenko
2017-06-02 14:01 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZ2u8mxCCCNCPpL3d6LACSjjHTCOyok9NWM0WuW0XY3HA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jlee@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).