From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82942C43334 for ; Mon, 18 Jul 2022 13:43:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234857AbiGRNne (ORCPT ); Mon, 18 Jul 2022 09:43:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231367AbiGRNnd (ORCPT ); Mon, 18 Jul 2022 09:43:33 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 176FD248E9 for ; Mon, 18 Jul 2022 06:43:32 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id x91so15363806ede.1 for ; Mon, 18 Jul 2022 06:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hnfHfZxYNUZt/Px9ux9l14VbmfOCDnqYfPKEnB9z/no=; b=AnHZKs0DXJjOJJ00mzghBpIrSTeMvfnlR9SpjD+0Ngy7A25lxpgsbgrTvYadxfFs3i ekNFu09OZaRfC+OSxO0gfaj999gyBKfuM/LeR5If3pHoPFRtH4k1FZzxQy8nafE4J+13 1sOGaakvolq0P+RVcs1FvfHVBMtrxkF1vDqf8AtgQukbkKyygNZcQuIjluqtxl8uJn2T UYvOqJCH7oWlseBBo5CXUoNga7xLCDXaMahcsx9QARuGoI40pngooYzijLG3ph1sCgqF 58neSor1L1qoO18p4hB3BdBt5Itakel5WNzZ1rNACC/791SYMzUDDsp3tYBr/9qUCSOJ skMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hnfHfZxYNUZt/Px9ux9l14VbmfOCDnqYfPKEnB9z/no=; b=pz4yww3hQOqXn/rG+z7oPKTtPX3qN8ZzD41JtQOP8DTz9M35O6YJZd8odda5yzgpr/ TUtC7Wpp9c8N9kOYhQeabnPZzkaGINTiJgCJkPmEFRDuKBa4DjWsKgt7z19+VZaw06Sr oGKpTsYJRNrHwMQIQS+RrrEWh6qdoSsSlUoWBzY+xaTGHAo/2owp5ZDwahXVnwS7y3vi X/60B7vuJBWe5qHw23L9icafYIOydYySwmpxyv3aKpCeQBIxwsvkLNlgGP6Im/kCrRNZ doF6pSvGLr9fNhlQ4oY3CIbPclD00iGgsw8pm5Cx+9aPZyaz09NEcsTcooWSVTkDYfAo 8Ysg== X-Gm-Message-State: AJIora/qW/8nWbK9gRJitOuh3jLdnp6Jdo+Jf+AgsTOhm4hRRCzYrCDM hNnvjWVeKWo8jCKfejhP67lJpc5DKUP13HTz32Ukhw== X-Google-Smtp-Source: AGRyM1tUllg8yDsJKjb0ainm4ebnVZKH+EWWmJB7x63T+CXhnVAYvvjjahiW31mzwxL9T/Uk9p27OBGYW7hbzKVa2Kg= X-Received: by 2002:a05:6402:34ce:b0:43a:a4bb:27a6 with SMTP id w14-20020a05640234ce00b0043aa4bb27a6mr36844792edc.158.1658151810702; Mon, 18 Jul 2022 06:43:30 -0700 (PDT) MIME-Version: 1.0 References: <20220716233745.1704677-1-vladimir.oltean@nxp.com> In-Reply-To: <20220716233745.1704677-1-vladimir.oltean@nxp.com> From: Linus Walleij Date: Mon, 18 Jul 2022 15:43:19 +0200 Message-ID: Subject: Re: [PATCH 0/2] Fix kernel splats on boot with armada-37xx irqchip driver To: Vladimir Oltean Cc: linux-arm-kernel@lists.infradead.org, Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?B?TWFyZWsgQmVow7pu?= , =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sun, Jul 17, 2022 at 1:38 AM Vladimir Oltean wrote: > Due to these splats on boot, lockdep disables itself on Armada 37xx and > we fail to see further useful information about real deadlocks. > > For those in doubt, the approach to use raw spinlocks for irqchip > drivers has been previously discussed here and doesn't seem too > controversial. > https://lore.kernel.org/lkml/20210825205041.927788-1-vladimir.oltean@nxp.com/ > > Tested on the Turris MOX board. > > Vladimir Oltean (2): > pinctrl: armada-37xx: make irq_lock a raw spinlock to avoid invalid > wait context > pinctrl: armada-37xx: use raw spinlocks for regmap to avoid invalid > wait context Patches applied for fixes so they get some rotation in linux-next. Reviewers have some days to react before I send this to Torvalds. Should these even be tagged for stable? Yours, Linus Walleij