linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Chris Zankel <chris@zankel.net>,
	Max Filippov <jcmvbkbc@gmail.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	linux-xtensa@linux-xtensa.org
Subject: Re: [PATCH] gpio: xtensa: depend on HAVE_XTENSA_GPIO32
Date: Thu, 2 Jan 2014 13:07:24 +0100	[thread overview]
Message-ID: <CACRpkdZ7+=KDskPWDWsS--74DRyW+7_gzX7gpPu1EvkiWXkNMA@mail.gmail.com> (raw)
In-Reply-To: <70c25715a89328b38e636f5f1f84ca34e4590d58.1387177140.git.baruch@tkos.co.il>

On Mon, Dec 16, 2013 at 8:05 AM, Baruch Siach <baruch@tkos.co.il> wrote:

> Prevent build failure when the selected variant does not support GPIO32.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
(...)

>  config XTENSA_VARIANT_FSF
>         bool "fsf - default (not generic) configuration"
>         select MMU
> +       select HAVE_XTENSA_GPIO32

(...)
> +config HAVE_XTENSA_GPIO32
> +       bool
> +
>  config GPIO_XTENSA
>         bool "Xtensa GPIO32 support"
>         depends on XTENSA
> +       depends on HAVE_XTENSA_GPIO32

This is just a tautology, you don't need a helper bool
for this.

Instead just select GPIO_XTENSA from your affected
platforms.

The patch only needs to hit arch/arm/mach-xtensa/Kconfig.

Yours,
Linus Walleij

  parent reply	other threads:[~2014-01-02 12:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16  7:05 [PATCH] gpio: xtensa: depend on HAVE_XTENSA_GPIO32 Baruch Siach
2013-12-17 14:24 ` Max Filippov
2014-01-02 12:07 ` Linus Walleij [this message]
2014-01-02 12:18   ` Baruch Siach
2014-01-02 13:21     ` Linus Walleij
2014-01-02 13:33       ` Baruch Siach
2014-01-02 17:04         ` Linus Walleij
2014-01-02 18:00           ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdZ7+=KDskPWDWsS--74DRyW+7_gzX7gpPu1EvkiWXkNMA@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=baruch@tkos.co.il \
    --cc=chris@zankel.net \
    --cc=jcmvbkbc@gmail.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-xtensa@linux-xtensa.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).