From: Linus Walleij <linus.walleij@linaro.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH v2 2/4] gpio: Add a valid_mask getter
Date: Tue, 4 Mar 2025 08:56:51 +0100 [thread overview]
Message-ID: <CACRpkdZ=64sgZuyb9sEF6+kOVxPcBdiVvkGgQSio2wO3kpeChg@mail.gmail.com> (raw)
In-Reply-To: <50003ead72a41672ad25e90b7a273ce48f04c8c4.1740745270.git.mazziesaccount@gmail.com>
On Fri, Feb 28, 2025 at 1:35 PM Matti Vaittinen
<mazziesaccount@gmail.com> wrote:
> The valid_mask member of the struct gpio_chip is unconditionally written
> by the GPIO core at driver registration. It shouldn't be directly
> populated by drivers. This can be prevented by moving it from the struct
> gpio_chip to struct gpio_device, which is internal to the GPIO core.
>
> As a preparatory step, provide a getter function which can be used by
> those drivers which need the valid_mask information.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2025-03-04 7:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 12:35 [PATCH v2 0/4] gpio: Hide and obey valid_mask Matti Vaittinen
2025-02-28 12:35 ` [PATCH v2 1/4] gpio: Respect valid_mask when requesting GPIOs Matti Vaittinen
2025-03-04 7:55 ` Linus Walleij
2025-02-28 12:35 ` [PATCH v2 2/4] gpio: Add a valid_mask getter Matti Vaittinen
2025-03-04 7:56 ` Linus Walleij [this message]
2025-02-28 12:36 ` [PATCH v2 3/4] gpio: gpio-rcar: Drop direct use of valid_mask Matti Vaittinen
2025-03-04 7:57 ` Linus Walleij
2025-02-28 12:36 ` [PATCH v2 4/4] gpio: Hide valid_mask from direct assignments Matti Vaittinen
2025-03-04 7:57 ` Linus Walleij
2025-03-05 9:03 ` [PATCH v2 0/4] gpio: Hide and obey valid_mask Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZ=64sgZuyb9sEF6+kOVxPcBdiVvkGgQSio2wO3kpeChg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=brgl@bgdev.pl \
--cc=geert@linux-m68k.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).