From: Linus Walleij <linus.walleij@linaro.org>
To: Martyn Welch <martyn.welch@collabora.co.uk>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Martyn Welch <martyn.welch@collabora.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/5] gpio: pca953x: Add support for PCAL6534
Date: Thu, 15 Sep 2022 10:31:46 +0200 [thread overview]
Message-ID: <CACRpkdZBTfnRaFRLDb_OW5oGbtdC2=3VnrM1EL=_SmPVHBX-eQ@mail.gmail.com> (raw)
In-Reply-To: <20220914151558.536226-5-martyn.welch@collabora.co.uk>
On Wed, Sep 14, 2022 at 5:16 PM Martyn Welch
<martyn.welch@collabora.co.uk> wrote:
> From: Martyn Welch <martyn.welch@collabora.com>
>
> Add support for the NXP PCAL6534. This device is broadly a 34-bit version
> of the PCAL6524. However, whilst the registers are broadly what you'd
> expect for a 34-bit version of the PCAL6524, the spacing of the registers
> has been compacted. This has the unfortunate effect of breaking the bit
> shift based mechanism that is employed to work out register locations used
> by the other chips supported by this driver. To accommodate ths, callback
> functions have been added to allow alterate implementations of
> pca953x_recalc_addr() and pca953x_check_register() for the PCAL6534.
>
> Datasheet: https://www.nxp.com/docs/en/data-sheet/PCAL6534.pdf
> Datasheet: https://www.diodes.com/assets/Datasheets/PI4IOE5V6534Q.pdf
> Signed-off-by: Martyn Welch <martyn.welch@collabora.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
prev parent reply other threads:[~2022-09-15 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220914151558.536226-1-martyn.welch@collabora.co.uk>
2022-09-14 15:15 ` [PATCH v5 2/5] dt-bindings: gpio: pca95xx: add entry for pcal6534 and PI4IOE5V6534Q Martyn Welch
2022-09-14 15:15 ` [PATCH v5 3/5] gpio: pca953x: Fix pca953x_gpio_set_pull_up_down() Martyn Welch
2022-09-14 15:15 ` [PATCH v5 4/5] gpio: pca953x: Swap if statements to save later complexity Martyn Welch
2022-09-14 15:15 ` [PATCH v5 5/5] gpio: pca953x: Add support for PCAL6534 Martyn Welch
2022-09-15 8:31 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZBTfnRaFRLDb_OW5oGbtdC2=3VnrM1EL=_SmPVHBX-eQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@collabora.co.uk \
--cc=martyn.welch@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).