From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F598ECAAD3 for ; Thu, 15 Sep 2022 08:32:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229913AbiIOIcE (ORCPT ); Thu, 15 Sep 2022 04:32:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229883AbiIOIcC (ORCPT ); Thu, 15 Sep 2022 04:32:02 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D081A97B1D for ; Thu, 15 Sep 2022 01:31:58 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id w28so1888588edi.7 for ; Thu, 15 Sep 2022 01:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=BIGBGBntdDKXqz/EQ3wuUT7hkmXxVvDzgAVe4vykiSY=; b=yB81I5DoaRjvmvKPiQmh0m/cBng4BWgK5Qla/cakP8oIj9kCayNAXgW0wTwyfKwZxd ewdJAB1k9Zcx9DAbbO2t3tP420rxDp6GbvckBuv27CUc4OjH0jOqJvFEWB3mayhSt9T0 bEAoGe3+/d/m3U1b1l5zNimmLef/g9rMRbSbXf4gzitGncExS7H0nCbTTyXIGuuo3Osi 9ns0Mpq6yzQjciWf/wCUroLk88RJhED0OczgJMos2+oy837zxBkWXIbAn2GVz3HWT3kH z5XpwDh/2yRk7Sinp/NzhoHSs2zx7dMn2c+veJuo41nzBL6aPdhT6VGA5qVppCM2cgZg W1UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=BIGBGBntdDKXqz/EQ3wuUT7hkmXxVvDzgAVe4vykiSY=; b=uUR9pcuPy4CtmRhYRiGSNK9qTGSJw/4gsm3FmGrIEEoGsP2bMlAiB19bbMojjCQBQZ d5Ol7GdcnGc38+577APBKVCQWw8OVMmuXAXtc3ZimSGWiSztdLU7YQv6j2DxhuJ37XnZ VTUgsY0l6u0yU719gVlx8yym+cQmGg8iXg0Q/xmq9EYfXZD+lvdXkqu3UIUxChpSACVT zPNVH4vbTXUetNVKC085alRydYR4kDdj+4fNfOHakun9lp5kvIthyVDgbR1I07drf9Rk QttGKRMYyF1KORAQQEK1QFS5gDy4ZZLIv8aFQ6N5KWpCKJdrTskx4IGJJ4jeYYYdO6fS O2Yw== X-Gm-Message-State: ACrzQf1vBP635B4pNPPZt5UkfN3dIPruPnpmVVdaTRciX4FgS0dHLJJs 3kQxQMxUD4gVqEnWoipS+KzUl1RfNui77PV5YxLlfQ== X-Google-Smtp-Source: AMsMyM6IUmfXjYAHjh+YBY278q1u5kbWH0c6BrprUo1crA8ni+iao3OLyM8Rkyz4KRI7AQpfdN4PLTbrCl0YiHvnpJI= X-Received: by 2002:a05:6402:190f:b0:452:d6ba:a150 with SMTP id e15-20020a056402190f00b00452d6baa150mr4945425edz.126.1663230717413; Thu, 15 Sep 2022 01:31:57 -0700 (PDT) MIME-Version: 1.0 References: <20220914151558.536226-1-martyn.welch@collabora.co.uk> <20220914151558.536226-5-martyn.welch@collabora.co.uk> In-Reply-To: <20220914151558.536226-5-martyn.welch@collabora.co.uk> From: Linus Walleij Date: Thu, 15 Sep 2022 10:31:46 +0200 Message-ID: Subject: Re: [PATCH v5 5/5] gpio: pca953x: Add support for PCAL6534 To: Martyn Welch Cc: Bartosz Golaszewski , Martyn Welch , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Sep 14, 2022 at 5:16 PM Martyn Welch wrote: > From: Martyn Welch > > Add support for the NXP PCAL6534. This device is broadly a 34-bit version > of the PCAL6524. However, whilst the registers are broadly what you'd > expect for a 34-bit version of the PCAL6524, the spacing of the registers > has been compacted. This has the unfortunate effect of breaking the bit > shift based mechanism that is employed to work out register locations used > by the other chips supported by this driver. To accommodate ths, callback > functions have been added to allow alterate implementations of > pca953x_recalc_addr() and pca953x_check_register() for the PCAL6534. > > Datasheet: https://www.nxp.com/docs/en/data-sheet/PCAL6534.pdf > Datasheet: https://www.diodes.com/assets/Datasheets/PI4IOE5V6534Q.pdf > Signed-off-by: Martyn Welch Reviewed-by: Linus Walleij Yours, Linus Walleij