From: Linus Walleij <linus.walleij@linaro.org>
To: kernel test robot <lkp@intel.com>
Cc: Shreeya Patel <shreeya.patel@collabora.com>,
bgolaszewski@baylibre.com, wsa@kernel.org, krisman@collabora.com,
sebastian.reichel@collabora.com, kbuild-all@lists.01.org,
kernel@collabora.com, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL
Date: Thu, 11 Nov 2021 21:40:27 +0100 [thread overview]
Message-ID: <CACRpkdZFX2xvFSjjg2Kwh4vn4zNoCfnp_xRmFmtVffADdokkoQ@mail.gmail.com> (raw)
In-Reply-To: <202111101719.VzKfSYAQ-lkp@intel.com>
On Wed, Nov 10, 2021 at 10:16 AM kernel test robot <lkp@intel.com> wrote:
> drivers/gpio/gpiolib.c: In function 'gpiod_to_irq':
> >> drivers/gpio/gpiolib.c:3068:15: error: 'struct gpio_chip' has no member named 'irq'
> 3068 | if (gc->irq.chip) {
> | ^~
Right you need an #ifdef CONFIG_GPIOLIB_IRQCHIP in this
case I would try:
if (IS_ENABLED(CONFIG_GPIOLIB_IRQCHIP) && gc->irq.chip)
hoping the compiler is smart enough to deal with that
(but I'm not sure it is)
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-11-11 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 22:05 [PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL Shreeya Patel
2021-10-24 21:49 ` Linus Walleij
2021-11-10 9:15 ` kernel test robot
2021-11-11 20:40 ` Linus Walleij [this message]
2021-11-11 20:58 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZFX2xvFSjjg2Kwh4vn4zNoCfnp_xRmFmtVffADdokkoQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=kbuild-all@lists.01.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sebastian.reichel@collabora.com \
--cc=shreeya.patel@collabora.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).