From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC179C433EF for ; Thu, 11 Nov 2021 20:40:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B89561207 for ; Thu, 11 Nov 2021 20:40:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233638AbhKKUn3 (ORCPT ); Thu, 11 Nov 2021 15:43:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233621AbhKKUn3 (ORCPT ); Thu, 11 Nov 2021 15:43:29 -0500 Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD355C061766 for ; Thu, 11 Nov 2021 12:40:39 -0800 (PST) Received: by mail-ot1-x332.google.com with SMTP id p11-20020a9d4e0b000000b0055a5741bff7so10743335otf.2 for ; Thu, 11 Nov 2021 12:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/q0Nd34GVOW6Vtxlxyie8tWymeB+50LKpXfiwevblXU=; b=XZHTFAlBg00W3A2TcZsb7/yLfISiWxehJykSZWM4yzx/UI2VWUY6k0sBYaSx2Zdg1m LtpJyG/iAG04oYD9l/YrHBSaq1sZt11hMnWgXYPVlqBAsW/AWYpD4ojphCVZUacyAxVU 2zcTrwTemXbvSwDga8q/o3xYzJAXiiaJQpmb5XMq0KiU3/xDwMnoB55ab27Iec9k0UAf fYJ1y5Zy1wY5TI0ttf9RyILiu7XyD3GZOIqySy+OuxAXLped/3ENBcQcqouh9y0H1XhH shJmLQSHbBPTt7KIZ0ZoC0s/KDdKwsty03sbid0k70qCYYDep8V61zmd78tw0NTVkMzL 3Kfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/q0Nd34GVOW6Vtxlxyie8tWymeB+50LKpXfiwevblXU=; b=ZAd9cv+uymUSsn+HxkQ4GMr0hrADuYPUAEAQk91RFoKc6WUOofwaHbNg2vxZLxI+IE qO6mfEUet6//gGou45BkJxCHdvPX+Y8CHy26I9vTcHLoXl5aPAKIIyPCtnXo39VbK47d 6aK2xVcXKiK5QA/xr1M94bNVoDS8WFucJ4omQ6/+jm+F1LVmBiUZG/2mcSJvbmInKsA1 bvhjVyEe1sJD+oGNV1QLdZPowcqW3BsBrUNFqcZXE+WpyOjavedvFw7QPgbsxU2Qbbd6 IoNU6MOQeqAX2XFc7UaLKXJudT73aBvXV21D2tSlJD1zvo3SHr2n8VmkG/luBn1zZvjj zPag== X-Gm-Message-State: AOAM533n+IJQSblVnqFUsD0BWMNv1r3YkguW3FDcDoITeh6oXTm1zbJV kfWRfhvxzI+qS7yHVKqpKNrVrGcqgt//bpG/4uRVtlmLGjE= X-Google-Smtp-Source: ABdhPJySsR95LrrExB2lAp4D7yILSqjeWebOdJCZOAFeTEf1VDzCywTgpKbXhktGmNdDUukENe/NseuXLB+TFyiClIY= X-Received: by 2002:a9d:6348:: with SMTP id y8mr8309151otk.179.1636663239280; Thu, 11 Nov 2021 12:40:39 -0800 (PST) MIME-Version: 1.0 References: <20211018220504.8301-1-shreeya.patel@collabora.com> <202111101719.VzKfSYAQ-lkp@intel.com> In-Reply-To: <202111101719.VzKfSYAQ-lkp@intel.com> From: Linus Walleij Date: Thu, 11 Nov 2021 21:40:27 +0100 Message-ID: Subject: Re: [PATCH v2] gpio: Return EPROBE_DEFER if gc->to_irq is NULL To: kernel test robot Cc: Shreeya Patel , bgolaszewski@baylibre.com, wsa@kernel.org, krisman@collabora.com, sebastian.reichel@collabora.com, kbuild-all@lists.01.org, kernel@collabora.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Nov 10, 2021 at 10:16 AM kernel test robot wrote: > drivers/gpio/gpiolib.c: In function 'gpiod_to_irq': > >> drivers/gpio/gpiolib.c:3068:15: error: 'struct gpio_chip' has no member named 'irq' > 3068 | if (gc->irq.chip) { > | ^~ Right you need an #ifdef CONFIG_GPIOLIB_IRQCHIP in this case I would try: if (IS_ENABLED(CONFIG_GPIOLIB_IRQCHIP) && gc->irq.chip) hoping the compiler is smart enough to deal with that (but I'm not sure it is) Yours, Linus Walleij